-
Notifications
You must be signed in to change notification settings - Fork 221
USHIFT-6074: Add support on releases scenarios to use artifacts from konflux #5596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@agullon: This pull request references USHIFT-6074 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/retest |
@ggiguash Very small difference. The only difference is the MicroShift version under test. In this PR, the bootc image is fetched from In periodics scenarios the version under test is fetched from final repositories, meaning it's already GA published. There is an exception to the previous statement: if no z-stream exist yet (for example in |
@ggiguash The goal of this PR is to test, during the Release Testing process, the MicroShfit bootc images produced by konflux before they are GA. We need to validate the artifacts before they are GA. For this reason, in the code added for this PR there's no a fallback mechanism into the GA'ed images. Instead, the bootc images under test are always fecthed from |
|
/retest |
|
@agullon: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@agullon: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified remove |
|
@agullon: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
|
||
| # Set the release type to ec, rc or zstream | ||
| LATEST_RELEASE_TYPE="ec" | ||
| # Latest Release info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should make appropriate changes to generate_common_version.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right, it got merge after this change. I'll do it.
test/bin/common_versions.sh
Outdated
| if [[ "${LATEST_RELEASE_TYPE}" == "ec" ]]; then | ||
| KONFLUX_LREL_RELEASE_IMAGE_URL="https://mirror.openshift.com/pub/openshift-v4/$(uname -m)/microshift/ocp-dev-preview/${LATEST_RELEASE_VERSION}/el9/bootc-pullspec.txt" | ||
| else | ||
| KONFLUX_LREL_RELEASE_IMAGE_URL="https://mirror.openshift.com/pub/openshift-v4/$(uname -m)/microshift/ocp/${LATEST_RELEASE_VERSION}/el9/bootc-pullspec.txt" | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to discuss this. Currently, pre-release bootc image references are published at openshift mirror, but this is not how we agreed with the ART team originally.
/hold
|
/hold until we agree with ART team a common place to share the MicroShift bootc images |
|
/test e2e-aws-tests-bootc-release e2e-aws-tests-bootc-release-arm |
|
/retest |
1 similar comment
|
/retest |
|
@agullon: This pull request references USHIFT-6074 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-tests |
Co-authored-by: Jon Cope <[email protected]>
Co-authored-by: Jon Cope <[email protected]>
|
/retest |
1 similar comment
|
/retest |
|
@agullon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add 2 new scenarios to test latest released microshift-bootc image created from konflux. This image can be fetched from different places:
registry.redhat.ioregistry.stage.redhat.iohttps://mirror.openshift.com/pub/openshift-v4/${UNAME_M}/microshift/ocp-dev-preview/https://mirror.openshift.com/pub/openshift-v4/${UNAME_M}/microshift/ocp/