Skip to content

Conversation

xrajesh
Copy link
Contributor

@xrajesh xrajesh commented Sep 15, 2025

Description

Added hideIcon field for icon off , when the Admin wants to turn off OLS icon for users who does not have access.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci openshift-ci bot requested review from bparees and raptorsun September 15, 2025 02:39
@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xrajesh
Copy link
Contributor Author

xrajesh commented Sep 22, 2025

/test fips-image-scan-operator

@xrajesh
Copy link
Contributor Author

xrajesh commented Sep 22, 2025

/test Red Hat Konflux / operator-e2e-tests-417 / ols-bundle

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2025

@xrajesh: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test bundle-e2e-4-18
/test ci-index-lightspeed-bundle-test
/test fips-image-scan-operator
/test generate
/test images
/test lint
/test security
/test unit

Use /test all to run all jobs.

In response to this:

/test Red Hat Konflux / operator-e2e-tests-417 / ols-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xrajesh
Copy link
Contributor Author

xrajesh commented Sep 22, 2025

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2025

@xrajesh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bundle-e2e-4-19 2dd21c9 link true /test bundle-e2e-4-19

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants