Skip to content

Conversation

blublinsky
Copy link
Contributor

Description

Type of change

  • Refactor
  • [ x] New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • [ x] I have performed a self-review of my code.
  • [ x] PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Copy link

openshift-ci bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@blublinsky blublinsky force-pushed the mcp-headers-secret-refs branch 2 times, most recently from 2add1f1 to cd6a58a Compare October 19, 2025 11:15
additionalProperties:
type: string
description: Headers to send to the MCP server
description: |-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle generation needed here

@raptorsun
Copy link
Contributor

logics look good, just need regenerate bundle.
before merging, we need coordinate this PR with #1079 to make sure the bundle test passes

@blublinsky blublinsky force-pushed the mcp-headers-secret-refs branch 2 times, most recently from 067499f to b66b5dc Compare October 20, 2025 10:57
@blublinsky
Copy link
Contributor Author

/retest

5 similar comments
@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@syedriko
Copy link
Contributor

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky blublinsky force-pushed the mcp-headers-secret-refs branch from b66b5dc to db153b6 Compare October 21, 2025 15:43
Copy link

openshift-ci bot commented Oct 21, 2025

@blublinsky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants