Skip to content

Conversation

raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Oct 16, 2025

do not merge

Signed-off-by: Haoyu Sun <[email protected]>
@raptorsun
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2025
Copy link

openshift-ci bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 16, 2025

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@raptorsun
Copy link
Contributor Author

raptorsun commented Oct 16, 2025

missing image problem , need to push PF5 console image to https://quay.io/organization/openshift-lightspeed

  2025-10-16T13:38:48Z	INFO	Container waiting	{"pod": "lightspeed-console-plugin-6bbc489b4b-6zwbp", "container": "lightspeed-console-plugin", "reason": "ImagePullBackOff", "message": "Back-off pulling image \"quay.io/openshift-lightspeed/lightspeed-console-plugin-pf5:latest\""}
  2025-10-16T13:38:48Z	INFO	Pod condition not met	{"pod": "lightspeed-console-plugin-6bbc489b4b-6zwbp", "type": "Ready", "status": "False", "reason": "ContainersNotReady", "message": "containers with unready status: [lightspeed-console-plugin]"}
  2025-10-16T13:38:48Z	INFO	Pod condition not met	{"pod": "lightspeed-console-plugin-6bbc489b4b-6zwbp", "type": "ContainersReady", "status": "False", "reason": "ContainersNotReady", "message": "containers with unready status: [lightspeed-console-plugin]"}

@raptorsun
Copy link
Contributor Author

/retest

@raptorsun
Copy link
Contributor Author

service e2e test failure
watsonx tool, permission issue

=================================== FAILURES ===================================
___________________________ test_tool_calling_events ___________________________

    @pytest.mark.tool_calling
    def test_tool_calling_events() -> None:
        """Check the endpoint for tool calling in event format."""
        with metrics_utils.RestAPICallCounterChecker(
            pytest.metrics_client, STREAMING_QUERY_ENDPOINT
        ):
            cid = suid.get_suid()
            response = post_with_defaults(
                STREAMING_QUERY_ENDPOINT,
                json={
                    "conversation_id": cid,
                    "query": "Get me current running pods in openshift-lightspeed namespace",
                    "media_type": constants.MEDIA_TYPE_JSON,
                },
            )
            assert response.status_code == requests.codes.ok
            response_utils.check_content_type(response, constants.MEDIA_TYPE_JSON)
    
            events = parse_streaming_response_to_events(response.text)
            unique_events = {e["event"] for e in events}
            response_text = construct_response_from_streamed_events(events).lower()
    
            # Sometime granite doesn't summarize well,
            # response may contain actual tool commands.
>           assert re.search(
                r"(lightspeed-app-server|\[\"pods\", \"-n\", \"openshift-lightspeed\"\])",
                response_text,
            )
E           assert None
E            +  where None = <function search at 0x7f25ff3d8220>('(lightspeed-app-server|\\[\\"pods\\", \\"-n\\", \\"openshift-lightspeed\\"\\])', "apologies for the confusion. it seems there's an issue with the permissions for listing pods across all namespaces. a...nt with the `cluster-admin` role.\n\nplease ensure you have the necessary permissions to perform the requested action.")
E            +    where <function search at 0x7f25ff3d8220> = re.search

tests/e2e/test_streaming_query_endpoint.py:644: AssertionError
- generated xml file: /workspace/artifacts/junit_e2e_watsonx_tool_calling.xml --
============================== slowest durations ===============================
8.47s call     test_streaming_query_endpoint.py::test_rag_question
6.83s call     test_query_endpoint.py::test_rag_question
4.96s call     test_query_endpoint.py::test_tool_calling
4.85s call     test_streaming_query_endpoint.py::test_tool_calling_events
4.52s call     test_streaming_query_endpoint.py::test_tool_calling_text

(10 durations < 0.005s hidden.  Use -vv to show these durations.)
=========================== short test summary info ============================
FAILED tests/e2e/test_streaming_query_endpoint.py::test_tool_calling_events
================= 1 failed, 4 passed, 70 deselected in 32.09s ==================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant