Skip to content

adding console images pf5 and pf6 #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

adding console images pf5 and pf6 #1062

wants to merge 1 commit into from
+20 −14

Conversation

blublinsky
Copy link
Contributor

Description

Type of change

  • [ x] Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign blublinsky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@blublinsky blublinsky mentioned this pull request Oct 14, 2025
Closed
10 tasks
raptorsun
raptorsun reviewed Oct 15, 2025
View reviewed changes
config/default/kustomization.yaml Outdated
- op: add
path: /spec/template/spec/containers/0/args/-
value: --console-image=quay.io/openshift-lightspeed/lightspeed-console-plugin:latest
- op: add
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need regenerate the bundle, too
files in bundle/ should reflect this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@blublinsky blublinsky force-pushed the pf5-pf6-updated branch 4 times, most recently from b241ac2 to 6d9a99a Compare October 17, 2025 08:21
@blublinsky
Copy link
Contributor Author

/retest

4 similar comments
@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

8 similar comments
@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

@blublinsky
Copy link
Contributor Author

/retest

1 similar comment
@JoaoFula
Copy link
Contributor

/retest

@blublinsky blublinsky force-pushed the pf5-pf6-updated branch 2 times, most recently from 6839256 to 40b503b Compare October 22, 2025 10:27
@blublinsky
Copy link
Contributor Author

/retest

@JoaoFula JoaoFula mentioned this pull request Oct 22, 2025
Open
11 tasks
@syedriko
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2025

@blublinsky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@blublinsky blublinsky closed this Oct 23, 2025
@blublinsky
Copy link
Contributor Author

replaced with 2 new PRs: #1088 and the one for bundle update to follow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

1 more reviewer

@raptorsun raptorsun raptorsun left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blublinsky @JoaoFula @syedriko @raptorsun @openshift-merge-robot