Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-2233: [CPO Refactor] Refactor cluster-storage-operator #5312

Merged
merged 1 commit into from
Jan 15, 2025
Merged

HOSTEDCP-2233: [CPO Refactor] Refactor cluster-storage-operator #5312

merged 1 commit into from
Jan 15, 2025

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Dec 17, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 17, 2024 •
edited by openshift-ci bot
Loading

@muraee: This pull request references HOSTEDCP-2233 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and enxebre December 17, 2024 17:32
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Dec 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Dec 17, 2024
@muraee muraee force-pushed the refactor-storage branch 2 times, most recently from af8b930 to 0950825 Compare December 19, 2024 12:55
@muraee
Copy link
Contributor Author

muraee commented Jan 7, 2025

/retest-required

@enxebre
Copy link
Member

enxebre commented Jan 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b26ec01 and 2 for PR HEAD 0950825 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@muraee
Copy link
Contributor Author

muraee commented Jan 8, 2025

/retest

1 similar comment
@muraee
Copy link
Contributor Author

muraee commented Jan 8, 2025

/retest

@enxebre
Copy link
Member

enxebre commented Jan 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e08020b and 2 for PR HEAD 6605c6b in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e08020b and 2 for PR HEAD 6605c6b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2877c7a and 1 for PR HEAD 6605c6b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a39bf24 and 0 for PR HEAD 6605c6b in total

@openshift-ci-robot
Copy link

/hold

Revision 6605c6b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2025
@muraee
Copy link
Contributor Author

muraee commented Jan 13, 2025

/retest-required

@muraee
Copy link
Contributor Author

muraee commented Jan 14, 2025

/retest-required

1 similar comment
@muraee
Copy link
Contributor Author

muraee commented Jan 14, 2025

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@muraee
Copy link
Contributor Author

muraee commented Jan 15, 2025

/retest-required

@enxebre
Copy link
Member

enxebre commented Jan 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@muraee
Copy link
Contributor Author

muraee commented Jan 15, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
@muraee
Copy link
Contributor Author

muraee commented Jan 15, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c89c2e5 and 2 for PR HEAD 8b99360 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 01d9533 into openshift:main Jan 15, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@enxebre enxebre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muraee @openshift-ci-robot @enxebre