Skip to content

SSCSI-254: Configurable secret rotation and WIF support for SSCSI#2012

Open
chiragkyal wants to merge 1 commit into
openshift:masterfrom
chiragkyal:configure-secret-rotation-and-wif
Open

SSCSI-254: Configurable secret rotation and WIF support for SSCSI#2012
chiragkyal wants to merge 1 commit into
openshift:masterfrom
chiragkyal:configure-secret-rotation-and-wif

Conversation

@chiragkyal
Copy link
Copy Markdown
Member

@chiragkyal chiragkyal commented May 16, 2026

Summary

This enhancement proposal adds configurable secret rotation and workload identity federation (WIF) support to the OpenShift Secrets Store CSI Driver Operator via the ClusterCSIDriver CR.

Changes

  • Extends CSIDriverConfigSpec with a new SecretsStore discriminated union
    variant containing secretRotation and tokenRequests fields.
  • The operator will dynamically propagate these settings to:
    • The storage.k8s.io/v1 CSIDriver object (requiresRepublish, tokenRequests)
    • The driver DaemonSet container args (--enable-secret-rotation, --rotation-poll-interval)
  • Aligns with upstream Secrets Store CSI Driver v1.6.0 which replaced the internal
    rotation controller with kubelet-native requiresRepublish.

Tracking

/cc @mytreya-rh @dobsonj

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 16, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 16, 2026

@chiragkyal: This pull request references SSCSI-254 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign suleymanakbas91 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: chiragkyal <ckyal@redhat.com>
@chiragkyal chiragkyal force-pushed the configure-secret-rotation-and-wif branch from 00a6104 to a49110c Compare May 16, 2026 20:00
@chiragkyal chiragkyal marked this pull request as ready for review May 18, 2026 06:46
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2026
@chiragkyal
Copy link
Copy Markdown
Member Author

/cc @mytreya-rh @dobsonj

@openshift-ci openshift-ci Bot requested review from dobsonj and mytreya-rh May 18, 2026 06:54
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants