Skip to content

OCPBUGS-83863: Strip debug symbols from Go binaries #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdodson wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Open

OCPBUGS-83863: Strip debug symbols from Go binaries #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ CMDS=livenessprobe
all: build

include release-tools/build.make
LDFLAGS = -s -w
Copy link
Copy Markdown

@jsafrane jsafrane May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Starting a few separate threads)
Why is it necessary in the livenessprobe and not other OCP images? IIRC, we don't stripe any CSI sidecar and most probably no OCP image.

Is there any document that says that OCP binaries need to be stripped?

Copy link
Copy Markdown
Member Author

@sdodson sdodson May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on that now openshift/enhancements#2021

Copy link
Copy Markdown

@jsafrane jsafrane May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is upstream Makefile. If we really need to strip the binary, it would be better to export this env, var in Dockerfile.openshift.rhel7, which we already <carry>, and it won't conflict with any upstream changes to the Makefile.

Copy link
Copy Markdown
Member Author

@sdodson sdodson May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK I can refactor toward that

Copy link
Copy Markdown

@jsafrane jsafrane May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please use UPSTREAM: <carry>: in the commit message.


test: test-logcheck