Skip to content

[release-4.16] OCPBUGS-49300: PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

[release-4.16] OCPBUGS-49300: PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name #1292

merged 1 commit into from
Jan 28, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1290

/assign mrniranjan

use ROLE_WORKER_CNF environment variable to determine mcp name
79a20a4 
Instead of using hardcoded value of worker, use the mcp name
from ROLE_WORKER_CNF environment variable

Signed-off-by: Niranjan M.R <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 24, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-48826 has been cloned as Jira Issue OCPBUGS-49300. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-49300: PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name

In response to this:

This is an automated cherry-pick of #1290

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.16] OCPBUGS-48826: PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name [release-4.16] OCPBUGS-49300: PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name Jan 24, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 24, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-49300, which is invalid:

  • expected dependent Jira Issue OCPBUGS-48826 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1290

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dagrayvid and MarSik January 24, 2025 18:43
@mrniranjan
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 25, 2025
@openshift-ci-robot
Copy link
Contributor

@mrniranjan: This pull request references Jira Issue OCPBUGS-49300, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-48826 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-48826 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

Requesting review from QA contact:
/cc @mrniranjan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mrniranjan January 25, 2025 01:00
@mrniranjan
Copy link
Contributor

/test e2e-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 25, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

swatisehgal
swatisehgal reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @yanirq
for backport-risk-assessed label and approval

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2025
@ffromani
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@yanirq
Copy link
Contributor

yanirq commented Jan 28, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 28, 2025
@mrniranjan
Copy link
Contributor

/label cherry-pick-approved l

@mrniranjan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit eacd6ee into openshift:release-4.16 Jan 28, 2025
16 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-49300: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49300 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1290

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator
This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202501281835.p0.geacd6ee.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

@MarSik MarSik Awaiting requested review from MarSik

@mrniranjan mrniranjan Awaiting requested review from mrniranjan

1 more reviewer

@swatisehgal swatisehgal swatisehgal left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@mrniranjan mrniranjan

@yanirq yanirq

@swatisehgal swatisehgal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @mrniranjan @ffromani @yanirq @openshift-bot @swatisehgal