Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-47717: Fix context deadlines in ExecCommandOnPod() #1272

Open
wants to merge 1 commit into
base: release-4.14
Choose a base branch
from
Open

[release-4.14] OCPBUGS-47717: Fix context deadlines in ExecCommandOnPod() #1272

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1265

/assign Tal-or

@Tal-or
Fix context deadlines in ExecCommandOnPod()
2ad8056 
During testing on x86_64 cluster from an arm64 host, I\'ve
observed strange context deadlines when enabling stdin in
ExecCommandOnPod() function.

Disable stdin as it is not needed during non-interactive tests.

Signed-off-by: Talor Itzhak <[email protected]>
(cherry picked from commit
0e994c7)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 1, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-47683 has been cloned as Jira Issue OCPBUGS-47717. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-47717: [release-4.15][manual]: Fix context deadlines in ExecCommandOnPod()

In response to this:

This is an automated cherry-pick of #1265

/assign Tal-or

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-47683: [release-4.15][manual]: Fix context deadlines in ExecCommandOnPod() [release-4.14] OCPBUGS-47717: [release-4.15][manual]: Fix context deadlines in ExecCommandOnPod() Jan 1, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 1, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-47717, which is invalid:

  • expected dependent Jira Issue OCPBUGS-47683 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1265

/assign Tal-or

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 1, 2025
@openshift-ci openshift-ci bot requested review from swatisehgal and yanirq January 1, 2025 09:21
@mrniranjan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 1, 2025
@Tal-or
Copy link
Contributor

Tal-or commented Jan 2, 2025

/test e2e-hypershift

@Tal-or
Copy link
Contributor

Tal-or commented Jan 2, 2025

/retitle [release-4.14] OCPBUGS-47717: Fix context deadlines in ExecCommandOnPod()

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-47717: [release-4.15][manual]: Fix context deadlines in ExecCommandOnPod() [release-4.14] OCPBUGS-47717: Fix context deadlines in ExecCommandOnPod() Jan 2, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

swatisehgal
swatisehgal approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, swatisehgal
Once this PR has been reviewed and has the lgtm label, please assign kpouget for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal swatisehgal approved these changes

@yanirq yanirq Awaiting requested review from yanirq

Assignees

@swatisehgal swatisehgal

@Tal-or Tal-or

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @mrniranjan @Tal-or @swatisehgal