Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] PPC: correct EnableHardwareTuning flag value #1271

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] PPC: correct EnableHardwareTuning flag value #1271

wants to merge 1 commit into from

Conversation

shajmakh
Copy link
Contributor

By mistake this was overridden to always true in this PR: #1236 Correct this by setting the value equal to the passed value from the parsed data.

Signed-off-by: Shereen Haj [email protected]
(cherry picked from commit 827db75) (cherry picked from commit fc95cb0)

@shajmakh
PPC: correct EnableHardwareTuning flag value
258ad3c 
By mistake this was overridden to always `true` in this PR: openshift#1236
Correct this by setting the value equal to the passed value from the
parsed data.

Signed-off-by: Shereen Haj <[email protected]>
(cherry picked from commit 827db75)
(cherry picked from commit fc95cb0)
@openshift-ci openshift-ci bot requested review from rbaturov and yanirq December 31, 2024 00:18
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shajmakh
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shajmakh shajmakh changed the title PPC: correct EnableHardwareTuning flag value [release-4.17] PPC: correct EnableHardwareTuning flag value Dec 31, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 31, 2024

@shajmakh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

swatisehgal
swatisehgal reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal swatisehgal left review comments

@rbaturov rbaturov Awaiting requested review from rbaturov

@yanirq yanirq Awaiting requested review from yanirq

Assignees

@swatisehgal swatisehgal

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shajmakh @swatisehgal