Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: PPC: correct EnableHardwareTuning flag value #1269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shajmakh
Copy link
Contributor

By mistake this was overridden to always true in this PR: #1236 Correct this by setting the value equal to the passed value from the parsed data.

By mistake this was overridden to always `true` in this PR: openshift#1236
Correct this by setting the value equal to the passed value from the
parsed data.

Signed-off-by: Shereen Haj <[email protected]>
@openshift-ci openshift-ci bot requested review from rbaturov and yanirq December 31, 2024 00:13
Copy link
Contributor

openshift-ci bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shajmakh
Once this PR has been reviewed and has the lgtm label, please assign ffromani for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shajmakh shajmakh changed the title PPC: correct EnableHardwareTuning flag value NO-JIRA: PPC: correct EnableHardwareTuning flag value Dec 31, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 31, 2024
@openshift-ci-robot
Copy link
Contributor

@shajmakh: This pull request explicitly references no jira issue.

In response to this:

By mistake this was overridden to always true in this PR: #1236 Correct this by setting the value equal to the passed value from the parsed data.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@swatisehgal
Copy link
Contributor

/test okd-scos-e2e-aws-ovn

Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

@shajmakh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 827db75 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants