Skip to content

Conversation

shajmakh
Copy link
Contributor

By mistake this was overridden to always true in this PR: #1236 Correct this by setting the value equal to the passed value from the parsed data.

By mistake this was overridden to always `true` in this PR: openshift#1236
Correct this by setting the value equal to the passed value from the
parsed data.

Signed-off-by: Shereen Haj <[email protected]>
@openshift-ci openshift-ci bot requested review from rbaturov and yanirq December 31, 2024 00:13
@shajmakh shajmakh changed the title PPC: correct EnableHardwareTuning flag value NO-JIRA: PPC: correct EnableHardwareTuning flag value Dec 31, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 31, 2024
@openshift-ci-robot
Copy link
Contributor

@shajmakh: This pull request explicitly references no jira issue.

In response to this:

By mistake this was overridden to always true in this PR: #1236 Correct this by setting the value equal to the passed value from the parsed data.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@swatisehgal
Copy link
Contributor

/test okd-scos-e2e-aws-ovn

Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

@shajmakh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 827db75 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yanirq
Copy link
Contributor

yanirq commented Jan 5, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Jan 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shajmakh, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2025
@shajmakh
Copy link
Contributor Author

shajmakh commented Jan 6, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7428d36 into openshift:master Jan 6, 2025
16 of 17 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator
This PR has been included in build cluster-node-tuning-operator-container-v4.19.0-202501061010.p0.g7428d36.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants