OCPBUGS-48317: PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name #1261

mrniranjan · 2024-12-21T08:58:48Z

In the current ppc tests, we are using mcp-name as worker. Instead of using hardcoded value of worker, use the mcp name from ROLE_WORKER_CNF environment variable

Instead of using hardcoded value of worker, use the mcp name from ROLE_WORKER_CNF environment variable Signed-off-by: Niranjan M.R <[email protected]>

swatisehgal

/lgtm

swatisehgal · 2025-01-03T10:50:56Z

/assign @MarSik @ffromani
for approval

swatisehgal · 2025-01-03T10:53:09Z

/test okd-scos-e2e-aws-ovn

mrniranjan · 2025-01-08T08:27:01Z

/retest-required

mrniranjan · 2025-01-08T11:21:24Z

/test okd-scos-e2e-aws-ovn

openshift-ci-robot · 2025-01-13T11:42:35Z

@mrniranjan: This pull request references Jira Issue OCPBUGS-48317, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In the current ppc tests, we are using mcp-name as worker. Instead of using hardcoded value of worker, use the mcp name from ROLE_WORKER_CNF environment variable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-01-13T11:42:38Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mrniranjan.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@mrniranjan: This pull request references Jira Issue OCPBUGS-48317, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.19.0) matches configured target version for branch (4.19.0)

bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In the current ppc tests, we are using mcp-name as worker. Instead of using hardcoded value of worker, use the mcp name from ROLE_WORKER_CNF environment variable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

shajmakh · 2025-01-13T12:02:08Z

test/e2e/performanceprofile/functests/10_performance_ppc/ppc.go

-				"--mcp-name=worker",
+				fmt.Sprintf("--mcp-name=%s", mcpName),


by default (in case the env variable isn't set) the target mcp would be worker-cnf, see here:
https://github.com/openshift/cluster-node-tuning-operator/blob/master/test/e2e/performanceprofile/functests/utils/consts.go#L38
does that make any difference in the expected results? is the gathered data have both mcps?

so when running under SNO environment we want to set ROLE_WORKER_CNF=master and run the tests

the change then solves SNO perfectly; what about MNO , do we always have worker-cnf mcp in the env from which we gathered the must-gather?

so in our CI for MNO , our CI creates a must-gather before running PPC tests, and by default we have worker-cnf label set.

shajmakh · 2025-01-13T14:12:17Z

/lgtm

yanirq · 2025-01-15T11:11:37Z

/approve

openshift-ci · 2025-01-15T11:11:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrniranjan, swatisehgal, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [yanirq]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ffromani · 2025-01-15T11:39:21Z

/label acknowledge-critical-fixes-only

test-only change, can't break the product

openshift-ci-robot · 2025-01-15T13:56:31Z

/retest-required

Remaining retests: 0 against base HEAD 4c5b2d2 and 2 for PR HEAD 1f2454d in total

openshift-ci · 2025-01-15T17:05:31Z

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-01-15T17:09:30Z

@mrniranjan: Jira Issue OCPBUGS-48317: All pull requests linked via external trackers have merged:

openshift/cluster-node-tuning-operator#1261

Jira Issue OCPBUGS-48317 has been moved to the MODIFIED state.

In response to this:

In the current ppc tests, we are using mcp-name as worker. Instead of using hardcoded value of worker, use the mcp name from ROLE_WORKER_CNF environment variable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-01-15T21:30:37Z

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator
This PR has been included in build cluster-node-tuning-operator-container-v4.19.0-202501152037.p0.g654909d.assembly.stream.el9.
All builds following this will include this PR.

mrniranjan · 2025-01-21T10:04:03Z

/cherry-pick release-4.18

openshift-cherrypick-robot · 2025-01-21T10:04:45Z

@mrniranjan: new pull request created: #1287

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from rbaturov and yanirq December 21, 2024 08:59

mrniranjan changed the title ~~use ROLE_WORKER_CNF environment variable to determine mcp name~~ PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name Dec 21, 2024

use ROLE_WORKER_CNF environment variable to determine mcp name

1f2454d

Instead of using hardcoded value of worker, use the mcp name from ROLE_WORKER_CNF environment variable Signed-off-by: Niranjan M.R <[email protected]>

mrniranjan force-pushed the ppc_fix_go branch from abb5b86 to 1f2454d Compare December 21, 2024 09:05

swatisehgal approved these changes Jan 3, 2025

View reviewed changes

openshift-ci bot assigned swatisehgal Jan 3, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025

openshift-ci bot assigned ffromani and MarSik Jan 3, 2025

mrniranjan changed the title ~~PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name~~ OCPBUGS-48317: PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name Jan 13, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 13, 2025

shajmakh reviewed Jan 13, 2025

View reviewed changes

openshift-ci bot assigned shajmakh Jan 13, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 15, 2025

openshift-merge-bot bot merged commit 654909d into openshift:master Jan 15, 2025
17 checks passed

openshift-cherrypick-robot mentioned this pull request Jan 21, 2025

[release-4.18] OCPBUGS-48666: PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name #1287

Merged

OCPBUGS-48317: PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name #1261

OCPBUGS-48317: PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name #1261

Uh oh!

Conversation

mrniranjan commented Dec 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swatisehgal left a comment

Choose a reason for hiding this comment

Uh oh!

swatisehgal commented Jan 3, 2025

Uh oh!

swatisehgal commented Jan 3, 2025

Uh oh!

mrniranjan commented Jan 8, 2025

Uh oh!

mrniranjan commented Jan 8, 2025

Uh oh!

openshift-ci-robot commented Jan 13, 2025

Uh oh!

openshift-ci bot commented Jan 13, 2025

Uh oh!

shajmakh Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

mrniranjan Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

shajmakh Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

mrniranjan Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

shajmakh commented Jan 13, 2025

Uh oh!

yanirq commented Jan 15, 2025

Uh oh!

openshift-ci bot commented Jan 15, 2025

Uh oh!

ffromani commented Jan 15, 2025

Uh oh!

openshift-ci-robot commented Jan 15, 2025

Uh oh!

openshift-ci bot commented Jan 15, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 15, 2025

Uh oh!

openshift-bot commented Jan 15, 2025

Uh oh!

mrniranjan commented Jan 21, 2025

Uh oh!

openshift-cherrypick-robot commented Jan 21, 2025

Uh oh!

Uh oh!

mrniranjan commented Dec 21, 2024 •

edited

Loading