Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name #1261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name #1261

wants to merge 1 commit into from

Conversation

mrniranjan
Copy link
Contributor

@mrniranjan mrniranjan commented Dec 21, 2024 •
edited
Loading

In the current ppc tests, we are using mcp-name as worker. Instead of using hardcoded value of worker, use the mcp name from ROLE_WORKER_CNF environment variable

@openshift-ci openshift-ci bot requested review from rbaturov and yanirq December 21, 2024 08:59
@mrniranjan mrniranjan changed the title use ROLE_WORKER_CNF environment variable to determine mcp name PPC_Test_fix: use ROLE_WORKER_CNF environment variable to determine mcp name Dec 21, 2024
use ROLE_WORKER_CNF environment variable to determine mcp name
1f2454d 
Instead of using hardcoded value of worker, use the mcp name
from ROLE_WORKER_CNF environment variable

Signed-off-by: Niranjan M.R <[email protected]>
swatisehgal
swatisehgal approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrniranjan, swatisehgal
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swatisehgal
Copy link
Contributor

/assign @MarSik @ffromani
for approval

@swatisehgal
Copy link
Contributor

/test okd-scos-e2e-aws-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

@mrniranjan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 1f2454d link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal swatisehgal approved these changes

@rbaturov rbaturov Awaiting requested review from rbaturov

@yanirq yanirq Awaiting requested review from yanirq

Assignees

@MarSik MarSik

@swatisehgal swatisehgal

@ffromani ffromani

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrniranjan @swatisehgal @MarSik @ffromani