WIP: PPC: unit: test sortTopology for expected output #1217
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shajmakh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| Cores: []*cpu.ProcessorCore{ | ||
| { | ||
| ID: 0, | ||
| LogicalProcessors: []int{2, 0, 1}, |
There was a problem hiding this comment.
why do we have 3 logical processors?
There was a problem hiding this comment.
I picked random values for the test. I can adjust the input if needed if we want it as much to resemble as much as possible an actual computer
There was a problem hiding this comment.
got it. 3 logical processor is unheard, I'd stick to 2.
The node topology contains several slices that later on are sorted and used to determine whether two nodes are equal. Add a unit test to verify this sorting is done as expected. Signed-off-by: Shereen Haj <[email protected]>
shajmakh
force-pushed
the
test-sortedv2
branch
from
50252a6 to
a0114e4
Compare
|
@shajmakh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
do-not-merge/hold
shajmakh
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
The node topology contains several slices that later on are sorted and used to determine whether two nodes are equal. Add a unit test to verify this sorting is done as expected.