Kms vault lifecycle#2165
Draft
gangwgr wants to merge 4 commits into
Draft
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughReplaces KMS volume/mount injection with a KMS plugin sidecar in the operator, extends managePods to accept a Secrets client, threads contexts through e2e encryption tests and library test helpers, and updates go.mod replace directives. ChangesKMS Sidecar Integration and Context-Aware E2E Testing
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 8 | ❌ 4❌ Failed checks (3 warnings, 1 inconclusive)
✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/test e2e-aws-operator-encryption-kms-ote |
Contributor
Author
|
/test e2e-aws-operator-encryption-kms |
Contributor
Author
|
/test e2e-gcp-operator-encryption-kms |
Contributor
Author
|
/test e2e-gcp-operator-encryption-kms-ote |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 140: The go.mod currently contains a replace directive rewiring
github.com/openshift/library-go to a personal fork (replace
github.com/openshift/library-go => github.com/gangwgr/library-go
v0.0.0-20260526073859-78d95d2abac4); remove that replace (or replace it with an
explicit upstream version of github.com/openshift/library-go) so CI/release
provenance is preserved, and if this fork is strictly temporary add a short
in-repo doc and a tracking issue/PR reference in the repository (e.g., note
scope, timeframe, and rollback plan) so the change is auditable and reversible.
In `@test/e2e-encryption-kms/encryption_kms.go`:
- Around line 127-131: The polling callbacks passed to
wait.PollUntilContextTimeout are currently swallowing errors from
operatorClient.Get by returning (false, nil); instead, propagate non-nil errors
so the poll aborts with the real error. Update the anonymous funcs used in
wait.PollUntilContextTimeout (the ones calling operatorClient.Get) to return
(false, err) when operatorClient.Get returns a non-nil error (or only suppress
specific transient errors if intentionally desired), and make the same change in
the second occurrence that currently swallows Get errors.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a2ae947c-7340-4f07-b683-fc6e7335705b
⛔ Files ignored due to path filters (16)
go.sumis excluded by!**/*.sumvendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/key_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/state_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/secret.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/pluginlifecycle/sidecar.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/pluginlifecycle/vault.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/secrets.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/state/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/kms/vault.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/perf_scenarios.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/scenarios.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (8)
go.modpkg/operator/targetconfigcontroller/targetconfigcontroller.gotest/e2e-encryption-kms/encryption_kms.gotest/e2e-encryption-perf/encryption_perf_test.gotest/e2e-encryption-rotation/encryption_rotation_test.gotest/e2e-encryption/encryption_test.gotest/e2e/encryption.gotest/e2e/encryption_test.go
|
|
||
| replace github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1 | ||
|
|
||
| replace github.com/openshift/library-go => github.com/gangwgr/library-go v0.0.0-20260526073859-78d95d2abac4 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify all replace directives and whether org->personal fork redirects exist.
set -euo pipefail
echo "== replace directives in go.mod =="
rg -n '^\s*replace\s+' go.mod
echo
echo "== specifically check library-go replacement =="
rg -n '^\s*replace\s+github\.com/openshift/library-go\s*=>' go.modRepository: openshift/cluster-kube-apiserver-operator
Length of output: 507
Avoid committing a go.mod replace from github.com/openshift/library-go to github.com/gangwgr/library-go
go.mod line 140 rewires github.com/openshift/library-go to a personal fork (github.com/gangwgr/library-go v0.0.0-20260526073859-78d95d2abac4), creating supply-chain provenance/reproducibility risk in CI/release builds unless this is strictly temporary and explicitly documented (scope, timeframe, rollback plan).
replace github.com/openshift/library-go => github.com/gangwgr/library-go v0.0.0-20260526073859-78d95d2abac4🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 140, The go.mod currently contains a replace directive
rewiring github.com/openshift/library-go to a personal fork (replace
github.com/openshift/library-go => github.com/gangwgr/library-go
v0.0.0-20260526073859-78d95d2abac4); remove that replace (or replace it with an
explicit upstream version of github.com/openshift/library-go) so CI/release
provenance is preserved, and if this fork is strictly temporary add a short
in-repo doc and a tracking issue/PR reference in the repository (e.g., note
scope, timeframe, and rollback plan) so the change is auditable and reversible.
gangwgr
force-pushed
the
kms-vault-lifecycle
branch
from
0e4a0e1 to
d20f728
Compare
Contributor
Author
|
/test e2e-gcp-operator-encryption-kms |
There was a problem hiding this comment.
♻️ Duplicate comments (2)
go.mod (1)
140-140:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAvoid merging a long-lived
replaceto a personal fork.Keeping
github.com/openshift/library-goredirected togithub.com/gangwgr/library-goingo.modrisks non-reproducible upstream builds and weakens dependency provenance. Prefer upstream/org-hosted source before merge, or explicitly document this as temporary with rollback tracking.#!/bin/bash set -euo pipefail echo "== library-go replacement in go.mod ==" rg -n '^replace github\.com/openshift/library-go =>' go.mod echo echo "== any in-repo documentation for temporary fork usage ==" rg -n 'library-go.*replace|gangwgr/library-go|temporary|rollback|tracking issue|follow-up' README* docs/ || true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` at line 140, The go.mod currently replaces github.com/openshift/library-go with a personal fork (replace github.com/openshift/library-go => github.com/gangwgr/library-go ...), which should not be merged long-term; change this by removing or reverting that replace directive and instead point to the upstream module (or a vetted org-hosted fork) or, if this is strictly temporary, add a clear comment in the repository (README or docs) documenting why the replace exists, its expiration/rollback plan and a tracking issue/PR number so maintainers can follow up; update or remove the replace line referencing github.com/gangwgr/library-go accordingly and ensure any CI/build docs mention the temporary override.test/e2e-encryption-kms/encryption_kms.go (1)
127-131:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPropagate
Geterrors in poll conditions instead of swallowing them.Returning
(false, nil)on non-transientoperatorClient.Get(...)errors hides real failures and can turn immediate errors into opaque timeouts.Suggested fix
err := wait.PollUntilContextTimeout(ctx, 10*time.Second, 10*time.Minute, true, func(ctx context.Context) (bool, error) { operator, err := operatorClient.Get(ctx, "cluster", metav1.GetOptions{}) if err != nil { - return false, nil + return false, fmt.Errorf("failed to get kube-apiserver operator: %w", err) } ... })err := wait.PollUntilContextTimeout(ctx, 10*time.Second, 20*time.Minute, true, func(ctx context.Context) (bool, error) { operator, err := operatorClient.Get(ctx, "cluster", metav1.GetOptions{}) if err != nil { - return false, nil + return false, fmt.Errorf("failed to get kube-apiserver operator: %w", err) } ... })Also applies to: 145-149
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e-encryption-kms/encryption_kms.go` around lines 127 - 131, The poll callback currently swallows non-transient errors from operatorClient.Get by returning (false, nil); change the callback to propagate real Get errors by returning (false, err) when operatorClient.Get(ctx, "cluster", metav1.GetOptions{}) returns an error so the poll exits immediately with the original error; update both the block around operatorClient.Get in the wait.PollUntilContextTimeout call at lines ~127-131 and the similar occurrence at ~145-149 to return the error instead of nil.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@go.mod`:
- Line 140: The go.mod currently replaces github.com/openshift/library-go with a
personal fork (replace github.com/openshift/library-go =>
github.com/gangwgr/library-go ...), which should not be merged long-term; change
this by removing or reverting that replace directive and instead point to the
upstream module (or a vetted org-hosted fork) or, if this is strictly temporary,
add a clear comment in the repository (README or docs) documenting why the
replace exists, its expiration/rollback plan and a tracking issue/PR number so
maintainers can follow up; update or remove the replace line referencing
github.com/gangwgr/library-go accordingly and ensure any CI/build docs mention
the temporary override.
In `@test/e2e-encryption-kms/encryption_kms.go`:
- Around line 127-131: The poll callback currently swallows non-transient errors
from operatorClient.Get by returning (false, nil); change the callback to
propagate real Get errors by returning (false, err) when operatorClient.Get(ctx,
"cluster", metav1.GetOptions{}) returns an error so the poll exits immediately
with the original error; update both the block around operatorClient.Get in the
wait.PollUntilContextTimeout call at lines ~127-131 and the similar occurrence
at ~145-149 to return the error instead of nil.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 18f76826-cdb4-439b-87b6-c7e4a6047f5b
⛔ Files ignored due to path filters (14)
go.sumis excluded by!**/*.sumvendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/key_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/state_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/secret.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/secrets.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/state/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/kms/vault.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/perf_scenarios.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/scenarios.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (7)
go.modtest/e2e-encryption-kms/encryption_kms.gotest/e2e-encryption-perf/encryption_perf_test.gotest/e2e-encryption-rotation/encryption_rotation_test.gotest/e2e-encryption/encryption_test.gotest/e2e/encryption.gotest/e2e/encryption_test.go
gangwgr
force-pushed
the
kms-vault-lifecycle
branch
from
d20f728 to
600987a
Compare
Contributor
Author
|
/test e2e-gcp-operator-encryption-kms |
There was a problem hiding this comment.
♻️ Duplicate comments (2)
go.mod (1)
140-140:⚠️ Potential issue | 🟠 MajorPersonal fork replace directive creates supply-chain risk.
The replace directive redirects
github.com/openshift/library-goto a personal fork, which was already flagged in previous reviews. This remains a supply-chain and provenance concern for CI/release builds.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` at line 140, The go.mod contains a risky replace directive pointing github.com/openshift/library-go to a personal fork; remove that replace directive in go.mod and restore a dependency on the official upstream module (github.com/openshift/library-go) with a vetted tagged version, or if a patched fork is required, host the fork in an org-controlled repository and reference that repo instead; after updating go.mod run `go mod tidy`/`go mod vendor` to regenerate go.sum and ensure CI verifies the provenance of the chosen module.test/e2e-encryption-kms/encryption_kms.go (1)
125-138:⚠️ Potential issue | 🟠 Major | ⚡ Quick winError swallowing in polling callbacks prevents early failure detection.
Both
WaitForDegradedandWaitForRecoverysuppress errors fromoperatorClient.Get(ctx, ...)by returning(false, nil). This issue was flagged in previous reviews and remains unresolved. Propagating these errors would provide faster, more actionable feedback when the operator client fails.Also applies to: 143-164
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e-encryption-kms/encryption_kms.go` around lines 125 - 138, The polling callbacks used in WaitForDegraded/WaitForRecovery swallow errors from operatorClient.Get by returning (false, nil), hiding client failures; update the callback inside wait.PollUntilContextTimeout to propagate errors from operatorClient.Get (return false, err) so polling fails fast on Get errors and test helpers (WaitForDegraded/WaitForRecovery) return that error upward instead of masking it.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@go.mod`:
- Line 140: The go.mod contains a risky replace directive pointing
github.com/openshift/library-go to a personal fork; remove that replace
directive in go.mod and restore a dependency on the official upstream module
(github.com/openshift/library-go) with a vetted tagged version, or if a patched
fork is required, host the fork in an org-controlled repository and reference
that repo instead; after updating go.mod run `go mod tidy`/`go mod vendor` to
regenerate go.sum and ensure CI verifies the provenance of the chosen module.
In `@test/e2e-encryption-kms/encryption_kms.go`:
- Around line 125-138: The polling callbacks used in
WaitForDegraded/WaitForRecovery swallow errors from operatorClient.Get by
returning (false, nil), hiding client failures; update the callback inside
wait.PollUntilContextTimeout to propagate errors from operatorClient.Get (return
false, err) so polling fails fast on Get errors and test helpers
(WaitForDegraded/WaitForRecovery) return that error upward instead of masking
it.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f2e2cd8e-efa1-41d4-9108-6b8f49b186e8
⛔ Files ignored due to path filters (14)
go.sumis excluded by!**/*.sumvendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/key_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/state_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/secret.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/secrets.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/state/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/kms/vault.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/perf_scenarios.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/scenarios.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (7)
go.modtest/e2e-encryption-kms/encryption_kms.gotest/e2e-encryption-perf/encryption_perf_test.gotest/e2e-encryption-rotation/encryption_rotation_test.gotest/e2e-encryption/encryption_test.gotest/e2e/encryption.gotest/e2e/encryption_test.go
bertinatto
reviewed
May 26, 2026
| // testKMSEncryptionInvalidImageRecovery tests that an invalid KMS plugin image | ||
| // causes degradation and that fixing the image restores the cluster. | ||
| func testKMSEncryptionInvalidImageRecovery(ctx context.Context, t testing.TB) { | ||
| librarykms.DeployUpstreamMockKMSPlugin(ctx, t, library.GetClients(t).Kube, librarykms.WellKnownUpstreamMockKMSPluginNamespace, librarykms.WellKnownUpstreamMockKMSPluginImage, librarykms.DefaultKMSPluginCount) |
Member
There was a problem hiding this comment.
hmm, I see the lifecycle changes in this PR (commit kms: support deploying Vault mock plugin), so I assume you want to rely on that to deploy the fake Vault plugin?
| return false, nil | ||
| } | ||
| for _, cond := range operator.Status.Conditions { | ||
| if cond.Type == "Degraded" && cond.Status == operatorv1.ConditionTrue { |
Member
There was a problem hiding this comment.
IIUC, this is a condition for kubeapiservers/cluster, is that right? If so, I think it has many conditions postfixed with Degraded, but none of them are just Degraded
gangwgr
force-pushed
the
kms-vault-lifecycle
branch
2 times, most recently
from
ef98104 to
f3530ad
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/e2e-encryption-kms/encryption_kms.go`:
- Around line 118-123: getKASOperatorConditions currently drops the test context
and uses context.Background() in its Get calls; change getKASOperatorConditions
to accept a context.Context parameter and replace context.Background() with that
ctx inside its Kubernetes Get calls, then update all call sites (e.g. the
closures passed to WaitForOperatorDegraded and WaitForOperatorAvailable such as
WaitForRecovery and the other wait closures) to pass the received ctx into
getKASOperatorConditions(t) -> getKASOperatorConditions(ctx, t) so
timeouts/cancellations propagate end-to-end.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 01aff279-b63a-433d-b68d-34d84cb09c73
⛔ Files ignored due to path filters (14)
go.sumis excluded by!**/*.sumvendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/key_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/state_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/secret.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/secrets.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/state/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/kms/vault.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/perf_scenarios.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/scenarios.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (7)
go.modtest/e2e-encryption-kms/encryption_kms.gotest/e2e-encryption-perf/encryption_perf_test.gotest/e2e-encryption-rotation/encryption_rotation_test.gotest/e2e-encryption/encryption_test.gotest/e2e/encryption.gotest/e2e/encryption_test.go
✅ Files skipped from review due to trivial changes (1)
- test/e2e-encryption-rotation/encryption_rotation_test.go
🚧 Files skipped from review as they are similar to previous changes (3)
- test/e2e-encryption-perf/encryption_perf_test.go
- test/e2e/encryption_test.go
- test/e2e/encryption.go
Contributor
Author
|
/test e2e-aws-operator-encryption-kms |
Contributor
Author
|
/test e2e-gcp-operator-encryption-kms |
gangwgr
force-pushed
the
kms-vault-lifecycle
branch
from
f3530ad to
92aa8ba
Compare
Contributor
Author
|
/test e2e-gcp-operator-encryption-kms |
gangwgr
force-pushed
the
kms-vault-lifecycle
branch
2 times, most recently
from
11a0db6 to
396667c
Compare
Contributor
Author
|
/test e2e-aws-operator-encryption-kms |
Contributor
Author
|
/test e2e-gcp-operator-encryption-kms |
gangwgr
force-pushed
the
kms-vault-lifecycle
branch
from
396667c to
98a3204
Compare
Contributor
Author
|
/test e2e-gcp-operator-encryption-kms |
Contributor
|
@gangwgr: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
Bot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Tests
Chores