WIP: Fake bump library-go to test#2162
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (12)
📒 Files selected for processing (6)
WalkthroughThe PR reformats the ginkgo v2 replace into a grouped ChangesModule Replacement Updates & e2e encryption tests
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 140: The go.mod currently replaces github.com/openshift/library-go with a
personal fork github.com/ardaguclu/library-go v0.0.0-20260521063842-0a19ee496ade
which weakens supply-chain trust; remove or revert the replace entry that points
github.com/openshift/library-go to github.com/ardaguclu/library-go (the replace
directive shown in the diff) and restore the canonical upstream module, or if
this fork is absolutely required obtain documented approval and move the
exception out of committed go.mod (e.g., use a local/private replace in CI-only
scripts or documented override) so shared CI/release uses the upstream module.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 133225b2-8724-4868-977d-879d1e729b6d
⛔ Files ignored due to path filters (8)
go.sumis excluded by!**/*.sumvendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/key_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/secret.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/secrets.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/state/types.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (1)
go.mod
| replace github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1 | ||
| replace ( | ||
| github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1 | ||
| github.com/openshift/library-go => github.com/ardaguclu/library-go v0.0.0-20260521063842-0a19ee496ade |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only verification: confirm the replacement currently points to a personal fork.
rg -n '^\s*replace\s*\(|github.com/openshift/library-go|github.com/ardaguclu/library-go' go.modRepository: openshift/cluster-kube-apiserver-operator
Length of output: 277
Block personal-fork replace for library-go in go.mod
go.mod line 140 replaces github.com/openshift/library-go with the personal fork github.com/ardaguclu/library-go v0.0.0-20260521063842-0a19ee496ade, weakening supply-chain trust and reproducibility for shared CI/release. Revert to the canonical upstream module before merge, or add a clearly documented and approved exception outside committed go.mod.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 140, The go.mod currently replaces
github.com/openshift/library-go with a personal fork
github.com/ardaguclu/library-go v0.0.0-20260521063842-0a19ee496ade which weakens
supply-chain trust; remove or revert the replace entry that points
github.com/openshift/library-go to github.com/ardaguclu/library-go (the replace
directive shown in the diff) and restore the canonical upstream module, or if
this fork is absolutely required obtain documented approval and move the
exception out of committed go.mod (e.g., use a local/private replace in CI-only
scripts or documented override) so shared CI/release uses the upstream module.
|
/uncc |
| func TestPerfEncryption(tt *testing.T) { | ||
| operatorClient := operatorencryption.GetOperator(tt) | ||
| library.TestPerfEncryption(tt, library.PerfScenario{ | ||
| library.TestPerfEncryption(context.TODO(), tt, library.PerfScenario{ |
There was a problem hiding this comment.
why not use library.TestPerfEncryption(tt.Context(), tt, library.PerfScenario{?
| // file | ||
| func TestEncryptionRotation(t *testing.T) { | ||
| library.TestEncryptionRotation(t, library.RotationScenario{ | ||
| library.TestEncryptionRotation(context.TODO(), t, library.RotationScenario{ |
|
|
||
| func TestEncryptionTypeIdentity(t *testing.T) { | ||
| library.TestEncryptionTypeIdentity(t, library.BasicScenario{ | ||
| library.TestEncryptionTypeIdentity(context.TODO(), t, library.BasicScenario{ |
|
|
||
| func testEncryptionTypeAESCBC(t testing.TB) { | ||
| library.TestEncryptionTypeAESCBC(t, library.BasicScenario{ | ||
| library.TestEncryptionTypeAESCBC(context.TODO(), t, library.BasicScenario{ |
There was a problem hiding this comment.
I'm planning to close this PR, once openshift/library-go#2212 merges. Thanks for review.
|
|
||
| func TestEncryptionTurnOnAndOff(t *testing.T) { | ||
| library.TestEncryptionTurnOnAndOff(t, library.OnOffScenario{ | ||
| library.TestEncryptionTurnOnAndOff(context.TODO(), t, library.OnOffScenario{ |
|
I'm closing this PR in favor of #2164 |
|
@ardaguclu: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ardaguclu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary by CodeRabbit
Chores
Tests