Fix failing unit tests in actuator remediation test

[n1r1]

@dhellmann reported that unit tests fails locally.

This PR fixes the failing test.

[n1r1]

/assign @dhellmann

[hardys]

Thanks - this fixes the local failures I was also seeing:

$ go test .
ok  	github.com/openshift/cluster-api-provider-baremetal/pkg/cloud/baremetal/actuators/machine	0.046s

make unit still has some errors elsewhere but that looks related to my environment.

Do we know how/why this worked in CI but failed locally?

/lgtm

[n1r1]

make unit still has some errors elsewhere but that looks related to my environment.

I also have some errors and thought it's only on my end. This is the error I'm getting:

?       github.com/openshift/cluster-api-provider-baremetal/pkg/apis/baremetal  [no test files]
2020/07/06 14:30:21 failed to start the controlplane. retried 5 times: timeout waiting for process kube-apiserver to start

Do you get the same error?
Anyway, it happens even without this PR changes.

Do we know how/why this worked in CI but failed locally?

That's a good question.
It was discussed in #72 and I see that @kirankt created a ticket to track this, though I have no idea where do these tickets live.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[dhellmann]

While debugging this last week I noticed that there are a lot of client calls where errors aren't being checked. Does the test client return errors in the way the real client does?

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[dhellmann]

See also #80

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[dhellmann]

/hold

let's stop consuming CI resources in a loop

[n1r1]

While debugging this last week I noticed that there are a lot of client calls where errors aren't being checked. Does the test client return errors in the way the real client does?

I think it does.
I guess we can also check the errors from the fake client as well.
Would you like me to do this as part of this PR or a separate one?

[dhellmann]

While debugging this last week I noticed that there are a lot of client calls where errors aren't being checked. Does the test client return errors in the way the real client does?

I think it does.
I guess we can also check the errors from the fake client as well.
Would you like me to do this as part of this PR or a separate one?

Either way is fine.

[n1r1]

/test e2e-metal-ipi

[n1r1]

/unhold

[dhellmann]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, hardys, n1r1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dhellmann,hardys]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment