Skip to content

Conversation

@CrystalChun
Copy link

@CrystalChun CrystalChun commented Mar 13, 2025

To fix the CVE, golang.org/x/oauth2 would need to be bumped to v0.26 or higher.
However, this requires a go version upgrade to 1.23, which is currently not
feasible for this version as there's no base image with go 1.23. To work
around this, we will use github.com/openshift/[email protected]
which contains the CVE fix and doesn't require a go version upgrade.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2025

@CrystalChun: This pull request references ACM-18173 which is a valid jira issue.

In response to this:

To fix CVE-2025-22868

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 13, 2025
@openshift-ci openshift-ci bot requested review from avishayt and gamli75 March 13, 2025 20:11
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2025
…2 v0.26.openshift.1

To fix the CVE, golang.org/x/oauth2 would need to be bumped to v0.26 or higher.
However, this requires a go version upgrade to 1.23, which is currently not
feasible for this version as there's no base image with go 1.23. To work
around this, we will use github.com/openshift/[email protected]
which contains the CVE fix and doesn't require a go version upgrade.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2025

@CrystalChun: This pull request references ACM-18173 which is a valid jira issue.

In response to this:

To fix the CVE, golang.org/x/oauth2 would need to be bumped to v0.26 or higher.
However, this requires a go version upgrade to 1.23, which is currently not
feasible for this version as there's no base image with go 1.23. To work
around this, we will use github.com/openshift/[email protected]
which contains the CVE fix and doesn't require a go version upgrade.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@CrystalChun
Copy link
Author

CrystalChun commented Mar 17, 2025

/retitle [release-ocm-2.13] ACM-18942: CVE-2025-22868 x/oauth2 => golang-oauth2 v0.26.openshift.1

@openshift-ci openshift-ci bot changed the title [release-ocm-2.13] ACM-18173: Upgrade golang.org/x/oauth2 to v0.28.0 [release-ocm-2.13] ACM-18942: CVE-2025-22868 x/oauth2 => golang-oauth2 v0.26.openshift.1 Mar 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2025

@CrystalChun: This pull request references ACM-18942 which is a valid jira issue.

In response to this:

To fix the CVE, golang.org/x/oauth2 would need to be bumped to v0.26 or higher.
However, this requires a go version upgrade to 1.23, which is currently not
feasible for this version as there's no base image with go 1.23. To work
around this, we will use github.com/openshift/[email protected]
which contains the CVE fix and doesn't require a go version upgrade.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun, gamli75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CrystalChun,gamli75]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CrystalChun
Copy link
Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Mar 19, 2025

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fec0370 into openshift:release-ocm-2.13 Mar 19, 2025
6 checks passed
@CrystalChun CrystalChun deleted the release-ocm-2.13 branch September 8, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants