Skip to content

Comments

SRVKP-7455: Update styling in console plugin due to changes in console#368

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift-pipelines:mainfrom
lokanandaprabhu:feature/SRVKP-7455
Apr 22, 2025
Merged

SRVKP-7455: Update styling in console plugin due to changes in console#368
openshift-merge-bot[bot] merged 3 commits intoopenshift-pipelines:mainfrom
lokanandaprabhu:feature/SRVKP-7455

Conversation

@lokanandaprabhu
Copy link
Member

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 10, 2025

@lokanandaprabhu: This pull request references SRVKP-7455 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "Pipelines 1.19.0" instead.

Details

In response to this:

Fixes:

https://issues.redhat.com/browse/SRVKP-7455

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from saumeya and vdemeester April 10, 2025 11:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footer buttons are not vertically align to center

image image

@vikram-raj
Copy link
Member

Pramaters field is not properly align

image

@vikram-raj
Copy link
Member

In the Start Pipeline modal in VolumClaimTemplate section, Storage class dropdown width is not proper

image

@lokanandaprabhu
Copy link
Member Author

Updated the PR by resolving the comments. PTAL.

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace between parameter title and text below. Space should be same as workspace field.

image

Parameters field takes 100% width.

image

@lokanandaprabhu
Copy link
Member Author

Resolved both the issues. PTAL.

@vikram-raj
Copy link
Member

In dark mode parameters field background color is broken

image

image

@lokanandaprabhu
Copy link
Member Author

Updated the PR. PTAL.

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 22, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 962adca into openshift-pipelines:main Apr 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants