Skip to content

Release 0.1.496#1140

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift-online:mainfrom
rcampos2029:release
Feb 24, 2026
Merged

Release 0.1.496#1140
openshift-merge-bot[bot] merged 2 commits intoopenshift-online:mainfrom
rcampos2029:release

Conversation

@rcampos2029
Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between ee3a4ef and 4f6f8ce.

📒 Files selected for processing (2)
  • CHANGES.md
  • version.go
✅ Files skipped from review due to trivial changes (1)
  • version.go

Walkthrough

Adds generated type and variable aliases for GcpDnsDomain and its list/builders/JSON helpers under clustersmgmt/v1, updates OpenAPI with a new GcpDnsDomain schema and extends DNSDomain, and bumps related module versions and the SDK version.

Changes

Cohort / File(s) Summary
Type & JSON alias files
clustersmgmt/v1/gcp_dns_domain_type_alias.go, clustersmgmt/v1/gcp_dns_domain_type_alias_json_alias.go, clustersmgmt/v1/gcp_dns_domain_list_type_alias_json_alias.go
Added generated type and JSON marshal/unmarshal aliases that re-export api_v1 types and functions for GcpDnsDomain and its list.
Builder alias files
clustersmgmt/v1/gcp_dns_domain_builder_alias.go, clustersmgmt/v1/gcp_dns_domain_list_builder_alias.go
Added generated builder and constructor aliases re-exporting api_v1 builders/constructors.
OpenAPI schema
openapi/clusters_mgmt/v1/openapi.json
Added GcpDnsDomain schema (fields: domain_prefix, network_id, project_id) and added gcp field to DNSDomain referencing it.
Dependency & version updates
go.mod, examples/go.mod, metamodel_generator/go.mod, version.go, CHANGES.md
Bumped api-model dependencies to v0.0.451, updated SDK Version to 0.1.496, and added release note entry.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset. Add a description explaining the release version bump, the API model update to v0.0.451, and the new GcpDnsDomain type being introduced.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Release 0.1.496' accurately reflects the main objective of the PR, which is to release version 0.1.496 with updated dependencies and generated API aliases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@davidleerh
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@clustersmgmt/v1/gcp_dns_domain_list_type_alias_json_alias.go`:
- Around line 38-39: The doc comment for ReadGcpDnsDomainList contains a
mismatched smart quote and single quote (“gcp_dns_domain'); update the comment
string above function ReadGcpDnsDomainList to use matching straight ASCII quotes
(e.g. 'gcp_dns_domain' or "gcp_dns_domain") so the exported docs render
correctly, and ensure the generator template that emits this comment uses plain
ASCII quotes instead of smart quotes.

In `@clustersmgmt/v1/gcp_dns_domain_type_alias.go`:
- Around line 40-42: The exported doc comment above the constant is mismatched:
it begins with "GcpDnsDomainNilKind" but the constant is named
GcpDnsDomainListNilKind; update the comment to start with
"GcpDnsDomainListNilKind" (or regenerate the template in the generator that
emits this doc) so the comment matches the exported identifier
GcpDnsDomainListNilKind and satisfies Go doc/lint rules.

In `@openapi/clusters_mgmt/v1/openapi.json`:
- Around line 14714-14717: The OpenAPI schema uses a sibling "description" next
to a "$ref" for the "gcp" property (referring to "GcpDnsDomain"), which is
ignored by OpenAPI 3.0 tooling; update the API model generator so properties
like "gcp" (and the similar "cluster_architecture") wrap the "$ref" inside an
"allOf" array and place the "description" at the same object level (i.e., allOf:
[{ "$ref": ... }], plus "description": "...") so the description is preserved in
generated docs/SDKs.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between d543bbf and ee3a4ef.

⛔ Files ignored due to path filters (3)
  • examples/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • metamodel_generator/go.sum is excluded by !**/*.sum
📒 Files selected for processing (10)
  • clustersmgmt/v1/gcp_dns_domain_builder_alias.go
  • clustersmgmt/v1/gcp_dns_domain_list_builder_alias.go
  • clustersmgmt/v1/gcp_dns_domain_list_type_alias_json_alias.go
  • clustersmgmt/v1/gcp_dns_domain_type_alias.go
  • clustersmgmt/v1/gcp_dns_domain_type_alias_json_alias.go
  • clustersmgmt/v1/openapi.go
  • examples/go.mod
  • go.mod
  • metamodel_generator/go.mod
  • openapi/clusters_mgmt/v1/openapi.json

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@rcampos2029 rcampos2029 changed the title Bump api model to v0.0.451 Release 0.1.496 Feb 24, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh, rcampos2029

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1afe0ff into openshift-online:main Feb 24, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants