OCPBUGS-49692: Add stopped to expected seed gen container statuses #734
Conversation
On podman 5.3.1 and systemd 252-49 (OpenShift 4.19) the seed generation container status, run with systemd-run via podman, when completing successfully (i.e. with exit code 0) it has status 'stopped'. Before that it had status 'exited'. Since we are expecting exit code 0 (success), expecting either of those statuses seems like a robust enough solution, instead of just expecting 'stopped'. - https://github.com/containers/podman/blob/48f874227827f5b705d809a50a7b23952b2ea6ab/libpod/define/containerstate.go#L23-L25 - https://github.com/containers/podman/blob/48f874227827f5b705d809a50a7b23952b2ea6ab/libpod/define/containerstate.go#L28-L30 Signed-off-by: Michail Resvanis <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Skipping CI for Draft Pull Request. |
|
/test all |
mresvanis
changed the title
|
@mresvanis: This pull request references Jira Issue OCPBUGS-49692, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@mresvanis: This pull request references Jira Issue OCPBUGS-49692, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Background / Context
On podman 5.3.1 and systemd 252-49 (OpenShift 4.19) the seed generation container status, run with systemd-run via podman, when completing successfully (i.e. with exit code 0) it has status
stopped. Before that it had statusexited.Issue / Requirement / Reason for change
In OCP 4.19 expecting the container status to be
exitedleads to the seed generation container being successful, but the SeedGenerator CR to be in a failed state.Solution / Feature Overview
Since we are anyway expecting exit code 0 (success), expecting either of those statuses (
exitedorstopped) seems like a robust enough solution, instead of just expectingstopped(in the case of OCP 4.19)./cc @tsorya