MGMT-19545: Replace seed cluster mirror registries in IBI preparation step

[mresvanis]

Background / Context

During the installation step of IBI, after setting up the new stateroot we precache the seed cluster's container images. Although there is support for mirror registries when creating the installation ISO, we currently don't account for the seed image containing pull-specs from mirror registries (e.g. the seed image was generated in a cluster with an OCP release image from a private registry). This results in the IBI preparation/installation step to fail when trying to pull images from the mirror registries of the seed cluster, instead of the target cluster's release mirror registries (or the original release registries if no mirror registries are configured on the target cluster).

Issue / Requirement / Reason for change

We want to support different mirror registry configuration between the seed and the target cluster, in order to enable IBI with seed images generated from disconnected SNO clusters.

Solution / Feature Overview

During the IBI preparation step before precaching the seed cluster's images, we can replace the seed release mirror registry with the target release (mirror) registry. That's exactly what we do in IBU here.

Implementation Details

In order to replace the seed release mirror registry with the target release (mirror) registry, we need the seed's release registry and the target's release registry. We can read the first one from the manifest.json that's included in the seed image.We can read the second one from the new IBI preparation configuration field ReleaseRegistry, which we will add during the creation of the installation ISO.

Other Information

[openshift-ci-robot]

@mresvanis: This pull request references MGMT-19545 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Background / Context

During the installation step of IBI, after setting up the new stateroot we precache the seed cluster's container images. Although there is support for mirror registries when creating the installation ISO, we currently don't account for the seed image containing pull-specs from mirror registries (i.e. the seed image was generated in a cluster with mirror registries configured). This results in the IBI preparation/installation step to fail when trying to pull images from the release mirror registries of the seed cluster, instead of the target cluster's release mirror registries (or the original release registries if no mirror registries are configured on the target cluster).

Issue / Requirement / Reason for change

We want to support different mirror registry configuration between the seed and the target cluster, in order to enable IBI with seed images generated from disconnected SNO clusters.

Solution / Feature Overview

During the IBI preparation step before precaching the seed cluster's images, we can replace the seed release mirror registry with the target release (mirror) registry. That's exactly what we do in IBU here.

Implementation Details

In order to replace the seed release mirror registry with the target release (mirror) registry, we need the seed's release registry and the target's release registry. We can read the first one from the manifest.json that's included in the seed image.We can read the second one from the new IBI preparation configuration field ReleaseRegistry, which we will add during the creation of the installation ISO.

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@mresvanis: This pull request references MGMT-19545 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Background / Context

During the installation step of IBI, after setting up the new stateroot we precache the seed cluster's container images. Although there is support for mirror registries when creating the installation ISO, we currently don't account for the seed image containing pull-specs from mirror registries (e.g. the seed image was generated in a cluster with an OCP release image from a private registry). This results in the IBI preparation/installation step to fail when trying to pull images from the mirror registries of the seed cluster, instead of the target cluster's release mirror registries (or the original release registries if no mirror registries are configured on the target cluster).

Issue / Requirement / Reason for change

We want to support different mirror registry configuration between the seed and the target cluster, in order to enable IBI with seed images generated from disconnected SNO clusters.

Solution / Feature Overview

During the IBI preparation step before precaching the seed cluster's images, we can replace the seed release mirror registry with the target release (mirror) registry. That's exactly what we do in IBU here.

Implementation Details

In order to replace the seed release mirror registry with the target release (mirror) registry, we need the seed's release registry and the target's release registry. We can read the first one from the manifest.json that's included in the seed image.We can read the second one from the new IBI preparation configuration field ReleaseRegistry, which we will add during the creation of the installation ISO.

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mresvanis]

/retest

[mresvanis]

/test ibu-e2e-flow

[tsorya]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tsorya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mresvanis]

/test integration