adding nfd feature rule package and new builder #882
Conversation
ggordaniRed
requested review from
wabouhamad,
kononovn,
trewest,
achuzhoy,
cdvultur and
klaskosk
as code owners
| @@ -53,9 +53,9 @@ require ( | |||
| gopkg.in/k8snetworkplumbingwg/multus-cni.v4 v4.0.2 | |||
| gopkg.in/yaml.v2 v2.4.0 | |||
| gorm.io/gorm v1.24.5 | |||
| k8s.io/api v0.30.5 | |||
| k8s.io/api v0.30.7 | |||
There was a problem hiding this comment.
Do the k8s go.mod changes have to happen here? We have an automated job to keep them up to date.
There was a problem hiding this comment.
I add new package by run make and make install maybe in the process this lib version changed
There was a problem hiding this comment.
@sebrandon1 It seems that NFD is not part of the sync job, thus it is causing this problem. What is currently the procedure? Should @ggordaniRed add config for the sync ?
There was a problem hiding this comment.
I'm not entirely sure how that sync all works. @kononovn?
There was a problem hiding this comment.
We shouldn't need a sync config for this operator unless it's causing issues with dependencies. There doesn't seem to be any actual changes between 0.30.5 and 0.30.7 of these libraries though
ggordaniRed
force-pushed
the
addingnfdrule
branch
from
a0ad42a to
28d8007
Compare
ggordaniRed
force-pushed
the
addingnfdrule
branch
from
28d8007 to
8f83e02
Compare
Adding new lib,builder,unit tests for nodfeaturerule object