Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.15] Register eventshub image for JobSink #989

Conversation

mgencur
Copy link

@mgencur mgencur commented Dec 17, 2024

The package must be registered so that ImageProducer can map it to the right image and replace it in the final yaml.

Backport from upstream.
This test was failing on ARM64 where the timing was slightly different.

@openshift-ci openshift-ci bot requested review from aliok and creydr December 17, 2024 10:31
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Author

mgencur commented Jan 6, 2025

/retest

The package must be registered so that ImageProducer can map it to the
right image and replace it in the final yaml.
@mgencur mgencur force-pushed the register_jobsink_package_v1.15 branch from 38a710a to 658c1e4 Compare January 6, 2025 07:01
Copy link

openshift-ci bot commented Jan 6, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Jan 6, 2025
@mgencur
Copy link
Author

mgencur commented Jan 6, 2025

/retest-required

@pierDipi pierDipi merged commit 8acbdf3 into openshift-knative:release-v1.15 Jan 7, 2025
31 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants