Skip to content

HPNEX-16: feat: add bundles with openshift-developer meta-package#489

Open
stbenjam wants to merge 1 commit into
openshift-eng:mainfrom
not-stbenjam:bundles
Open

HPNEX-16: feat: add bundles with openshift-developer meta-package#489
stbenjam wants to merge 1 commit into
openshift-eng:mainfrom
not-stbenjam:bundles

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented May 20, 2026

What this PR does / why we need it:

Adds a bundles/ directory with curated sets of APM packages. Includes the openshift-developer bundle and documents marketplace registration for plugins that depend on anthropics/claude-plugins-official.

Requires microsoft/apm#1422 first

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.

Summary by CodeRabbit

  • Documentation

    • Added comprehensive guide for APM bundles covering available options, registration prerequisites, and installation instructions for both global and project-scoped deployments, plus guidance for creating custom bundles.
  • New Features

    • Introduced the openshift-developer bundle with pre-configured dependencies and integration settings.

Adds a bundles/ directory with curated sets of APM packages. Includes
the openshift-developer bundle and documents marketplace registration
for plugins that depend on anthropics/claude-plugins-official.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested review from bryan-cox and cblecker May 20, 2026 17:41
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Walkthrough

This pull request introduces APM bundles documentation and an initial bundle configuration. The changes add a README explaining bundle concepts, installation workflows for global and project-scoped installs, and instructions for creating new bundles, along with the concrete openshift-developer bundle definition that specifies APM plugin dependencies and MCP endpoint configuration.

Changes

APM Bundles Documentation and Configuration

Layer / File(s) Summary
Bundle documentation and concepts
bundles/README.md
README documents what APM bundles are, lists available bundles, describes marketplace prerequisites for Anthropic Claude plugins, provides global and project-scoped installation instructions, and includes a step-by-step guide for creating new bundles with example apm.yml configuration.
OpenShift Developer bundle definition
bundles/openshift-developer/apm.yml
YAML bundle metadata and dependency configuration for openshift-developer bundle, including three APM plugins from openshift-eng/ai-helpers and an Atlassian MCP endpoint configured with HTTP transport and custom URL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

approved, lgtm

Suggested reviewers

  • brandisher
  • LuboTerifaj
🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Real People Names In Style References ✅ Passed No references to real people's names found in style references, plugin commands, documentation, or example prompts across bundles/README.md and bundles/openshift-developer/apm.yml.
No Assumed Git Remote Names ✅ Passed PR contains no hardcoded git remote names like "origin" or "upstream" in commands, documentation, or configuration files.
Git Push Safety Rules ✅ Passed PR adds only documentation (README.md) and configuration (apm.yml) files with no git push commands, force pushes, or unsafe push operations.
No Untrusted Mcp Servers ✅ Passed PR introduces only Atlassian's official MCP server (https://mcp.atlassian.com/v1/mcp), which is a trusted, commercially-supported product partnered with Anthropic—not an untrusted or random source.
Ai-Helpers Overlap Detection ✅ Passed PR modifies only bundles/README.md and apm.yml, which are outside check scope (plugins//commands, plugins//skills, agents/) and qualify for early termination as non-functional docs.
Title check ✅ Passed The title clearly summarizes the main change: adding a new bundles directory with the openshift-developer meta-package, which aligns with the file additions (bundles/README.md and bundles/openshift-developer/apm.yml).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@stbenjam stbenjam changed the title feat: add bundles with openshift-developer meta-package HPNEX-16: feat: add bundles with openshift-developer meta-package May 20, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 20, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 20, 2026

@stbenjam: This pull request references HPNEX-16 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Adds a bundles/ directory with curated sets of APM packages. Includes the openshift-developer bundle and documents marketplace registration for plugins that depend on anthropics/claude-plugins-official.

Requires microsoft/apm#1422 first

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.

Summary by CodeRabbit

  • Documentation

  • Added comprehensive guide for APM bundles covering available options, registration prerequisites, and installation instructions for both global and project-scoped deployments, plus guidance for creating custom bundles.

  • New Features

  • Introduced the openshift-developer bundle with pre-configured dependencies and integration settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bundles/README.md (1)

78-90: 💤 Low value

Consider adding an HTTP transport example for MCP.

The example shows transport: stdio, but the actual openshift-developer bundle uses transport: http with a url field. Adding an HTTP transport example would help users understand both configuration patterns.

📚 Optional documentation enhancement
 dependencies:
   apm:
     - openshift-eng/ai-helpers/plugins/jira
     - openshift-eng/ai-helpers/plugins/ci
   mcp:
     - name: some-mcp-server
       transport: stdio
+    - name: http-mcp-server
+      registry: false
+      transport: http
+      url: https://example.com/mcp
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bundles/README.md` around lines 78 - 90, Add an HTTP transport example next
to the existing MCP example so users see both patterns: keep the existing
dependencies->mcp block that uses "transport: stdio" and add a second mcp
example showing "transport: http" with a "url" field (and any optional fields
used by openshift-developer bundle) so it's clear how to configure an
HTTP-backed MCP entry; reference the same top-level "dependencies" and "mcp"
keys and include a brief comment about when to use "stdio" vs "http".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bundles/README.md`:
- Around line 78-90: Add an HTTP transport example next to the existing MCP
example so users see both patterns: keep the existing dependencies->mcp block
that uses "transport: stdio" and add a second mcp example showing "transport:
http" with a "url" field (and any optional fields used by openshift-developer
bundle) so it's clear how to configure an HTTP-backed MCP entry; reference the
same top-level "dependencies" and "mcp" keys and include a brief comment about
when to use "stdio" vs "http".

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7c220746-89df-41af-ab62-8b9fb00dc424

📥 Commits

Reviewing files that changed from the base of the PR and between d4833ba and 39982d1.

📒 Files selected for processing (2)
  • bundles/README.md
  • bundles/openshift-developer/apm.yml

@stbenjam
Copy link
Copy Markdown
Member Author

/hold

Pending some apm changes

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants