HPNEX-16: feat: add bundles with openshift-developer meta-package#489
HPNEX-16: feat: add bundles with openshift-developer meta-package#489stbenjam wants to merge 1 commit into
Conversation
Adds a bundles/ directory with curated sets of APM packages. Includes the openshift-developer bundle and documents marketplace registration for plugins that depend on anthropics/claude-plugins-official. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughThis pull request introduces APM bundles documentation and an initial bundle configuration. The changes add a README explaining bundle concepts, installation workflows for global and project-scoped installs, and instructions for creating new bundles, along with the concrete ChangesAPM Bundles Documentation and Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@stbenjam: This pull request references HPNEX-16 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bundles/README.md (1)
78-90: 💤 Low valueConsider adding an HTTP transport example for MCP.
The example shows
transport: stdio, but the actualopenshift-developerbundle usestransport: httpwith aurlfield. Adding an HTTP transport example would help users understand both configuration patterns.📚 Optional documentation enhancement
dependencies: apm: - openshift-eng/ai-helpers/plugins/jira - openshift-eng/ai-helpers/plugins/ci mcp: - name: some-mcp-server transport: stdio + - name: http-mcp-server + registry: false + transport: http + url: https://example.com/mcp🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bundles/README.md` around lines 78 - 90, Add an HTTP transport example next to the existing MCP example so users see both patterns: keep the existing dependencies->mcp block that uses "transport: stdio" and add a second mcp example showing "transport: http" with a "url" field (and any optional fields used by openshift-developer bundle) so it's clear how to configure an HTTP-backed MCP entry; reference the same top-level "dependencies" and "mcp" keys and include a brief comment about when to use "stdio" vs "http".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bundles/README.md`:
- Around line 78-90: Add an HTTP transport example next to the existing MCP
example so users see both patterns: keep the existing dependencies->mcp block
that uses "transport: stdio" and add a second mcp example showing "transport:
http" with a "url" field (and any optional fields used by openshift-developer
bundle) so it's clear how to configure an HTTP-backed MCP entry; reference the
same top-level "dependencies" and "mcp" keys and include a brief comment about
when to use "stdio" vs "http".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7c220746-89df-41af-ab62-8b9fb00dc424
📒 Files selected for processing (2)
bundles/README.mdbundles/openshift-developer/apm.yml
|
/hold Pending some apm changes |
What this PR does / why we need it:
Adds a bundles/ directory with curated sets of APM packages. Includes the openshift-developer bundle and documents marketplace registration for plugins that depend on anthropics/claude-plugins-official.
Requires microsoft/apm#1422 first
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Checklist:
Summary by CodeRabbit
Documentation
New Features