Skip to content

Conversation

@aalva500-prog
Copy link
Contributor

Description

This PR adds integration tests and documentation for PPL based dashboards covering NFW, CloudTrail, WAF, and VPC logs in Neo for CloudWatch Lake.

Changes

New Integration Tests:

  • Added NFW (Network Firewall) PPL dashboard integration tests
  • Added CloudTrail PPL dashboard integration tests
  • Added VPC Flow Logs PPL dashboard integration tests
  • Added WAF PPL dashboard integration tests
  • Reorganized PPL dashboard tests into dedicated dashboard/ package

Test Infrastructure:

  • Added new index mappings and test data for NFW, CloudTrail, VPC, and WAF logs

Documentation:

  • Added documentation for NFW, CloudTrail, VPC, and WAF PPL based dashboards integration tests

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Where exactly is this data from?

We had the issue with integrations that we committed a bunch of sample data and lost the source it was generated from. That would be a good thing to put in the docs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 We need to get some data from the actual real flow, like from the actual loggroup of VPC logs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me actually follow up on this. I do have some existing flow that I can export some sanitized data. Cuz even for the verification of query correctness, we may need some field with relatively high cardinality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data you see here is coming from my own S3 bucket, which I use during the integration creation workflow in OpenSearch Dashboards. However, this is not real data and it only has a few records, as the purpose of this exercise was to test query correctness specifically. I had to change the data to avoid exposing sensitive info also.

Copy link
Contributor Author

@aalva500-prog aalva500-prog Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the new workflow in PPL based dashboards the data should come directly from CW log groups, though. Apart from the NFW, the rest of the queries have been already tested by DQS team connecting directly with CW log groups. However, for NFW the data has been retrieved directly from own CW log groups, so the schema is correct, but I can add some more data if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be good, thanks @RyanL1997

Let me actually follow up on this. I do have some existing flow that I can export some sanitized data. Cuz even for the verification of query correctness, we may need some field with relatively high cardinality.

@aalva500-prog aalva500-prog requested a review from Swiddis November 4, 2025 18:48
Signed-off-by: Aaron Alvarez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants