Build: Centralise dependencies version - Pt1 #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-k-improving
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin and
noCharger
as code owners
10 tasks
currantw
reviewed
Feb 4, 2025
YANG-DB
previously approved these changes
Feb 5, 2025
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
andy-k-improving
dismissed stale reviews from YANG-DB and acarbonetto
via
2f637f7
andy-k-improving
force-pushed
the
ft-ak-gradle-dep-version-consolidate
branch
from
40998ea to
2f637f7
Compare
|
Updated comments, awaiting CI. |
|
@YANG-DB @acarbonetto I have updated the comments, which dismissed the approval. |
currantw
approved these changes
Feb 6, 2025
acarbonetto
approved these changes
Feb 6, 2025
|
@YANG-DB Hi can you have another look, I have added some comments on the Gradle file, which dismissed your original approval. |
YANG-DB
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to centralise certain dependencies which are commonly used across the project, and also serve as a perquisites to eventually migrate all versions declaration to Gradle version catalog, in order to avoid version conflict in the future, as the project codebase grows.
NO breaking change would be expected, as there is NO version upgrade || downgrade happen on any of the dependencies at this point.
Related Issues
Related to: #3257
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.