Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLQuery Utils support for Vaccum queries #3288

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Siritejagaddameedi
Copy link

Description

Add SQLQueryUtils support for Vacuum queries

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

  1. SQLQueryUtils didn't support for Vacuum queries

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Siri Teja Gaddameedi added 3 commits January 31, 2025 07:54
Signed-off-by: Siri Teja Gaddameedi <[email protected]>
Signed-off-by: Siri Teja Gaddameedi <[email protected]>
@@ -316,6 +316,31 @@ public Void visitAlterMaterializedViewStatement(
return super.visitAlterMaterializedViewStatement(ctx);
}

@Override
public Void visitVacuumCoveringIndexStatement(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate what was the issue without this?

@@ -140,6 +140,7 @@ void testExtractionFromFlintSkippingIndexQueries() {
+ " WHERE elb_status_code = 500 "
+ " WITH (auto_refresh = true)",
"DROP SKIPPING INDEX ON myS3.default.alb_logs",
"VACUUM SKIPPING INDEX ON myS3.default.alb_logs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test for MV vacuum?

@ykmr1224
Copy link
Collaborator

ykmr1224 commented Feb 7, 2025

Please follow-up on original PR: #3269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants