Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PPL parse command doc with limitation #3274

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Jan 29, 2025

Description

Update PPL documentation to clarify the missing field issue below in Limitations section.

Related Issues

#3265

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen added the documentation Improvements or additions to documentation label Jan 29, 2025
@dai-chen dai-chen self-assigned this Jan 29, 2025
acarbonetto
acarbonetto previously approved these changes Jan 29, 2025
docs/user/ppl/cmd/parse.rst Outdated Show resolved Hide resolved
docs/user/ppl/cmd/parse.rst Outdated Show resolved Hide resolved
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@dai-chen dai-chen merged commit bb732e8 into opensearch-project:main Feb 4, 2025
16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 4, 2025
* Update PPL parse command doc with limitation

Signed-off-by: Chen Dai <[email protected]>

* Address comments

Signed-off-by: Chen Dai <[email protected]>

* Fixed example

Signed-off-by: Chen Dai <[email protected]>

---------

Signed-off-by: Chen Dai <[email protected]>
(cherry picked from commit bb732e8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Feb 5, 2025
(cherry picked from commit bb732e8)

Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants