Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3030 Add flatten Command for Objects to PPL #3267

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

#3030 Add flatten Command for Objects to PPL #3267

wants to merge 54 commits into from
+1,205 −89

Conversation

currantw
Copy link
Contributor

@currantw currantw commented Jan 27, 2025 •
edited by acarbonetto
Loading

Signed-off-by: currantw [email protected]

Description

Implements flatten command for objects only.

Out of scope

Does not implement flattening for arrays or aliasing. This will come in a follow-up PR.

Related Issues

Part of scope of #3030.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@currantw currantw changed the title Add flatten command to ANTLR lexer and parser. #3030 Add flatten Command for Objects to PPL Jan 27, 2025
@currantw currantw marked this pull request as ready for review January 28, 2025 17:45
currantw added 15 commits February 6, 2025 10:59
@currantw
Update to maintain existing field.
d636911 
Signed-off-by: currantw <[email protected]>
@currantw
Update for test coverage
ed9e730 
Signed-off-by: currantw <[email protected]>
@currantw
Simplify Analyzer implementation
ebdbac9 
Signed-off-by: currantw <[email protected]>
@currantw
Rename cities dataset to flatten
ad85abb 
Signed-off-by: currantw <[email protected]>
@currantw
SpotlessApply
b20cb38 
Signed-off-by: currantw <[email protected]>
@currantw
Minor doc cleanup.
2b3d867 
Signed-off-by: currantw <[email protected]>
@currantw
Fix failing IT
4ca9054 
Signed-off-by: currantw <[email protected]>
@currantw
Update incorrect documentation in Analyzer.visitFlatten.
65cae37 
Signed-off-by: currantw <[email protected]>
@currantw
Update integ and doc tests to add another example of original field b…
6bb94aa 
…eing preserved.

Signed-off-by: currantw <[email protected]>
@currantw
Review comment - move example to Analyzer.visitFlatten Javadoc.
1064d19 
Signed-off-by: currantw <[email protected]>
@currantw
Review comment - update Analyzer.visitFlatten Javadoc to specify th…
e35bc40 
…at it also updates env, plus Javadoc formatting.

Signed-off-by: currantw <[email protected]>
@currantw
Review comment - remove unnecessary @Getter
5977966 
Signed-off-by: currantw <[email protected]>
@currantw
Review comments - add testStructNestedDeep test case
ca4357b 
Signed-off-by: currantw <[email protected]>
@currantw
Review comments - add testStructNestedDeep test case
db4944b 
Signed-off-by: currantw <[email protected]>
@currantw
Woops! Fix failing test.
5d0026b 
Signed-off-by: currantw <[email protected]>
@currantw currantw force-pushed the #3029_flatten_command branch from f465ce1 to 5d0026b Compare February 6, 2025 18:59
acarbonetto
acarbonetto reviewed Feb 7, 2025
View reviewed changes
core/src/main/java/org/opensearch/sql/analysis/Analyzer.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/analysis/Analyzer.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/analysis/Analyzer.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/analysis/Analyzer.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/analysis/Analyzer.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/utils/PathUtils.java Outdated Show resolved Hide resolved
core/src/test/java/org/opensearch/sql/expression/ip/IPFunctionsTest.java Outdated Show resolved Hide resolved
core/src/test/java/org/opensearch/sql/expression/ip/IPFunctionsTest.java Show resolved Hide resolved
core/src/test/java/org/opensearch/sql/planner/logical/LogicalFlattenTest.java Outdated Show resolved Hide resolved
core/src/test/java/org/opensearch/sql/planner/logical/LogicalFlattenTest.java Show resolved Hide resolved
@YANG-DB YANG-DB self-requested a review February 10, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanj-bitquill normanj-bitquill normanj-bitquill left review comments

@andy-k-improving andy-k-improving andy-k-improving left review comments

@acarbonetto acarbonetto acarbonetto left review comments

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@currantw @YANG-DB @normanj-bitquill @acarbonetto @andy-k-improving