Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add seder to transportPPLQueryResponse #2446

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,16 @@

package org.opensearch.sql.plugin.transport;

import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.UncheckedIOException;

import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.opensearch.core.action.ActionResponse;
import org.opensearch.core.common.io.stream.InputStreamStreamInput;
import org.opensearch.core.common.io.stream.OutputStreamStreamOutput;
import org.opensearch.core.common.io.stream.StreamInput;
import org.opensearch.core.common.io.stream.StreamOutput;

Expand All @@ -25,4 +31,22 @@ public TransportPPLQueryResponse(StreamInput in) throws IOException {
public void writeTo(StreamOutput out) throws IOException {
out.writeString(result);
}

public static TransportPPLQueryResponse fromActionResponse(ActionResponse actionResponse) {
dai-chen marked this conversation as resolved.
Show resolved Hide resolved
if (actionResponse instanceof TransportPPLQueryResponse) {
return (TransportPPLQueryResponse) actionResponse;
}

try (
ByteArrayOutputStream baos = new ByteArrayOutputStream();
OutputStreamStreamOutput osso = new OutputStreamStreamOutput(baos)) {
actionResponse.writeTo(osso);
try (StreamInput input = new InputStreamStreamInput(new ByteArrayInputStream(baos.toByteArray()))) {
return new TransportPPLQueryResponse(input);
}
} catch (IOException e) {
throw new UncheckedIOException("failed to parse ActionResponse into TransportPPLQueryResponse", e);
}

}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/

package org.opensearch.sql.plugin.transport;

import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.opensearch.core.action.ActionResponse;

import java.io.IOException;
import java.lang.reflect.InvocationTargetException;
import java.nio.file.Files;
import java.nio.file.Path;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;

public class TransportPPLQueryResponseTest {

@Rule public ExpectedException exceptionRule = ExpectedException.none();

@Test
public void testFromActionResponseSameClassloader() {
TransportPPLQueryResponse response1 = new TransportPPLQueryResponse("mock result");
TransportPPLQueryResponse response2 = TransportPPLQueryResponse.fromActionResponse(response1);
assertEquals(response1.getResult(), response2.getResult());
}

@Test
public void testFromActionResponseDifferentClassLoader() throws
ClassNotFoundException,
InstantiationException,
IllegalAccessException,
NoSuchMethodException,
InvocationTargetException {
ClassLoader loader = TransportPPLQueryResponseTest.class.getClassLoader();
String classFilePath = loader.getResource("org/opensearch/sql/plugin/transport/TransportPPLQueryResponse.class").getPath();

CustomClassLoader classLoader1 = new CustomClassLoader(classFilePath);
CustomClassLoader classLoader2 = new CustomClassLoader(classFilePath);

Class<?> class1 = classLoader1.findClass("org.opensearch.sql.plugin.transport.TransportPPLQueryResponse");
Class<?> class2 = classLoader2.findClass("org.opensearch.sql.plugin.transport.TransportPPLQueryResponse");

assertFalse(class1.isAssignableFrom(class2));
String result = "mock result";
TransportPPLQueryResponse response2 = TransportPPLQueryResponse.fromActionResponse((ActionResponse) class1.getDeclaredConstructor(String.class).newInstance(result));
assertEquals(result, response2.getResult());
}

}

class CustomClassLoader extends ClassLoader {

private final Path classFilePath;

public CustomClassLoader(String classFilePath) {
this.classFilePath = Path.of(classFilePath);
}

@Override
protected Class<?> findClass(String name) throws ClassNotFoundException {
try {
byte[] classBytes = Files.readAllBytes(classFilePath);
return defineClass(name, classBytes, 0, classBytes.length);
} catch (IOException e) {
throw new ClassNotFoundException("Failed to load class: " + name, e);
}
}
}
Loading