Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike support duplicate column names #1982

Conversation

acarbonetto
Copy link
Collaborator

Description

PoC created to add support for duplicate column names. Previously an error was thrown.
See discussions here and here.

Examples:

opensearchsql> select 1 AS `a`, 2 AS `a`, 3, 3;
fetched rows / total rows = 1/1
+-----+-----+-----+-----+
| a   | a   | 3   | 3   |
|-----+-----+-----+-----|
| 1   | 2   | 3   | 3   |
+-----+-----+-----+-----+
opensearchsql> select 1+1, 1+1;
fetched rows / total rows = 1/1
+-------+-------+
| 1+1   | 1+1   |
|-------+-------|
| 2     | 2     |
+-------+-------+

Issues Resolved

#785
#1382

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@MitchellGale
Copy link
Contributor

FYI - you have a file conflict @acarbonetto

@Swiddis
Copy link
Collaborator

Swiddis commented Dec 27, 2024

Is this still in progress? Should we close it?

@Swiddis
Copy link
Collaborator

Swiddis commented Dec 27, 2024

Closing as stale -- feel free to reopen if work is resumed

@Swiddis Swiddis closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants