Reuse contextStartIndex variable

Signed-off-by: Simeon Widdis <[email protected]>
opensearch-project · Jan 29, 2025 · 6642475 · 6642475
1 parent 9000314
commit 6642475
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/common/src/main/java/org/opensearch/sql/common/antlr/SyntaxAnalysisErrorListener.java b/common/src/main/java/org/opensearch/sql/common/antlr/SyntaxAnalysisErrorListener.java
@@ -48,11 +48,11 @@ private String getOffendingText(Token offendingToken) {
   }
 
   private String truncateQueryAtOffendingToken(String query, Token offendingToken) {
-    int contextStart = offendingToken.getStartIndex() - CONTEXT_TRUNCATION_THRESHOLD;
-    if (offendingToken.getStartIndex() - CONTEXT_TRUNCATION_THRESHOLD <= 3) {
+    int contextStartIndex = offendingToken.getStartIndex() - CONTEXT_TRUNCATION_THRESHOLD;
+    if (contextStartIndex < 3) { // The ellipses won't save us anything below the first 4 characters
       return query.substring(0, offendingToken.getStopIndex() + 1);
     }
-    return "..." + query.substring(contextStart, offendingToken.getStopIndex() + 1);
+    return "..." + query.substring(contextStartIndex, offendingToken.getStopIndex() + 1);
   }
 
   private String getDetails(Recognizer<?, ?> recognizer, String msg, RecognitionException e) {