Add robust input validation to MCP Server #4381
Open
+367
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rithin-pullela-aws <[email protected]>
rithin-pullela-aws
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
pyek-bot,
rbhavna,
sam-herman,
xinyual,
ylwu-amzn and
zane-neo
as code owners
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
|
|
||
| if (message instanceof McpSchema.JSONRPCRequest request) { | ||
| validateRequestId(request.id()); | ||
| validateMethod(request.method()); |
There was a problem hiding this comment.
Is it necessary to also validate request.params?
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validates MCP server's input.
Restrict the method, id, and JSON RPC values to safe/ acceptable values
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.