Skip to content

Make thread pool sizes configurable #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented May 9, 2025

Description

Allows configuration of thread pool sizes at startup using a static setting.

Check List

Reviewers please provide tech review of above doc PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.37%. Comparing base (7aec38e) to head (c2e71a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1139      +/-   ##
============================================
+ Coverage     77.33%   77.37%   +0.04%     
- Complexity     1096     1099       +3     
============================================
  Files           101      101              
  Lines          5308     5318      +10     
  Branches        511      511              
============================================
+ Hits           4105     4115      +10     
  Misses          954      954              
  Partials        249      249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@junweid62
Copy link
Collaborator

LGTM! Just curious — why do we need this feature?

@dbwiddis
Copy link
Member Author

dbwiddis commented May 9, 2025

LGTM! Just curious — why do we need this feature?

The existing sizes are assuming a single tenant cluster. For Multi-tenant implementation with many more tenants, we need to be able to have more simultaneous tenant provisioning.

I honestly think our thread pool sizes are too small as we're mostly just blocking waiting on the result of async REST calls.

@dbwiddis
Copy link
Member Author

dbwiddis commented May 9, 2025

Tests failing due to opensearch-project/job-scheduler#773, need upstream dependencies who depend on Guava to update.

@dbwiddis dbwiddis force-pushed the threadpool-setting branch from 8c62a33 to c2e71a3 Compare May 21, 2025 17:57
@dbwiddis dbwiddis merged commit 6fd68b2 into opensearch-project:main May 22, 2025
23 checks passed
@dbwiddis dbwiddis deleted the threadpool-setting branch May 22, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.1.0 Issues targeting release v3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants