-
Notifications
You must be signed in to change notification settings - Fork 51
Make thread pool sizes configurable #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
============================================
+ Coverage 77.33% 77.37% +0.04%
- Complexity 1096 1099 +3
============================================
Files 101 101
Lines 5308 5318 +10
Branches 511 511
============================================
+ Hits 4105 4115 +10
Misses 954 954
Partials 249 249 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LGTM! Just curious — why do we need this feature? |
The existing sizes are assuming a single tenant cluster. For Multi-tenant implementation with many more tenants, we need to be able to have more simultaneous tenant provisioning. I honestly think our thread pool sizes are too small as we're mostly just blocking waiting on the result of async REST calls. |
Tests failing due to opensearch-project/job-scheduler#773, need upstream dependencies who depend on Guava to update. |
src/main/java/org/opensearch/flowframework/common/FlowFrameworkSettings.java
Show resolved
Hide resolved
Signed-off-by: Daniel Widdis <[email protected]>
8c62a33
to
c2e71a3
Compare
Description
Allows configuration of thread pool sizes at startup using a static setting.
Check List
[ ] API changes companion pull request created.--signoff
.Reviewers please provide tech review of above doc PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.