Skip to content

Add neural sparse new models to doc #9915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhichao-aws
Copy link
Member

@zhichao-aws zhichao-aws commented May 16, 2025

Description

Add neural-sparse new v3 models and multilingual models to docs.
Remove neural sparse query max_token_score as it's deprecated for multiple versions.

Issues Resolved

N/A

Version

2.12 - latest

Frontend features

N/A

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@zhichao-aws
Copy link
Member Author

The PR's ready for review, thanks.

@kolchfa-aws
Copy link
Collaborator

@zhichao-aws Thanks! Is the max_token_score completely removed from the code or just deprecated?

@zhichao-aws
Copy link
Member Author

@kolchfa-aws We still read the arg max_token_score in the code, but it doesn't have any impact on the execution. We read it just to keep BWC (if not read it, OpenSearch will throw exception). I think we'd better remove it from the doc to avoid misleading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants