Skip to content

Document that the unified highlighter supports matched_field #9793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nomoa
Copy link
Contributor

@nomoa nomoa commented Apr 30, 2025

This highlighter should now support matched_field add a quick mention about it.

Description

Describe what this change achieves.

Issues Resolved

Relates to opensearch-project/OpenSearch#18166

Version

3.1.0 and onwards

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws
Copy link
Collaborator

Hi @nomoa, please let me know when this is ready for doc review. Thanks!

@nomoa
Copy link
Contributor Author

nomoa commented May 19, 2025

@kolchfa-aws opensearch-project/OpenSearch#18166 just got merged, I think this should be ready for review, thanks!

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nomoa! Just one suggestion.

@kolchfa-aws
Copy link
Collaborator

@nomoa Also, please resolve merge conflicts so we can merge this PR. Thanks!

This highlighter should now support matched_field add a quick mention
about it.

Signed-off-by: David Causse <[email protected]>
@nomoa nomoa force-pushed the unified-highlighter-support-matched-fields branch from 6369d3b to c822879 Compare May 20, 2025 15:48
@nomoa
Copy link
Contributor Author

nomoa commented May 21, 2025

@kolchfa-aws thanks for the review! I addressed your comments and resolved the conflicts.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolchfa-aws kolchfa-aws merged commit 57d5961 into opensearch-project:main May 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes PR: Include this PR in the automated release notes v3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants