-
Notifications
You must be signed in to change notification settings - Fork 561
Document that the unified highlighter supports matched_field #9793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that the unified highlighter supports matched_field #9793
Conversation
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Hi @nomoa, please let me know when this is ready for doc review. Thanks! |
@kolchfa-aws opensearch-project/OpenSearch#18166 just got merged, I think this should be ready for review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @nomoa! Just one suggestion.
@nomoa Also, please resolve merge conflicts so we can merge this PR. Thanks! |
This highlighter should now support matched_field add a quick mention about it. Signed-off-by: David Causse <[email protected]>
6369d3b
to
c822879
Compare
@kolchfa-aws thanks for the review! I addressed your comments and resolved the conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This highlighter should now support matched_field add a quick mention about it.
Description
Describe what this change achieves.
Issues Resolved
Relates to opensearch-project/OpenSearch#18166
Version
3.1.0 and onwards
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.