Plugin metrics injection #5372
Open
Plugin metrics injection #5372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
san81
requested review from
sb2k16,
chenqi0805,
engechas,
srikanthjg,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Jan 30, 2025
| beanFactory.registerSingleton(configuration.getClass().getName(), configuration); | ||
| } | ||
| if (pluginSetting != null) { |
There was a problem hiding this comment.
Would this change allow us to remove the following line without breaking existing code?
Also, at a high-level, can we consolidate these completely?
| */ | ||
| public BeanFactory createPluginSpecificContext(Class[] markersToScan, Object configuration) { | ||
| public BeanFactory createPluginSpecificContext(Class[] markersToScan, Object configuration, final PluginSetting pluginSetting) { |
There was a problem hiding this comment.
This change resulted in a lot of other changes. This indicates that we should have a class to handle these parameters. We actually already have something similar in the ComponentPluginArgumentsContext. I think consolidating this will help clean up the code. See my other comment below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making the PluginMetrics as an injectable bean so that we can simply inject this bean in any other spring bean.
Also, clean up some unused variables in Jira source.
Fixed a flaky test in Otel trace processor
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.