Fix Postgres stream processing #5367
Merged
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hai Yan <[email protected]>
oeyh
requested review from
sb2k16,
chenqi0805,
engechas,
san81,
srikanthjg,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter and
dlvenable
as code owners
divbok
reviewed
Jan 28, 2025
| @@ -158,7 +158,7 @@ void processRelationMessage(ByteBuffer msg) { | |||
| } | |||
|
|
|||
| void processCommitMessage(ByteBuffer msg) { | |||
| int flag = msg.getInt(); | |||
| int flag = msg.get(); | |||
There was a problem hiding this comment.
Any particular reason why we are using get and not getInt() here?
There was a problem hiding this comment.
get() gets the next byte. getInt() gets the next 4 bytes. This flag has only one byte.
divbok
approved these changes
Jan 28, 2025
dinujoh
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a few issues in Postgres stream processing following #5310
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.