Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to deprecated processor names otel_trace_raw and service_map_stateful #5017

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

linghengqian
Copy link
Contributor

@linghengqian linghengqian commented Oct 3, 2024

Description

[Describe what this change achieves]

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Copy link
Collaborator

@chenqi0805 chenqi0805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linghengqian Thanks a lot for the change! LGTM

Copy link
Contributor Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14 tests completed, 1 failed
> Task :data-prepper-plugins:otel-trace-raw-processor:test FAILED

OTelTraceRawProcessorTest > traceGroupCacheMaxSize_provides_an_upper_bound(long, int) > [1] 1, 4 FAILED
    java.lang.AssertionError at OTelTraceRawProcessorTest.java:270


Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':data-prepper-plugins:otel-trace-raw-processor:test'.

@dlvenable
Copy link
Member

14 tests completed, 1 failed
> Task :data-prepper-plugins:otel-trace-raw-processor:test FAILED

OTelTraceRawProcessorTest > traceGroupCacheMaxSize_provides_an_upper_bound(long, int) > [1] 1, 4 FAILED
    java.lang.AssertionError at OTelTraceRawProcessorTest.java:270


Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':data-prepper-plugins:otel-trace-raw-processor:test'.

Yes, this is a flaky test on Java 11. We can merge it.

@dlvenable dlvenable merged commit 72e2f27 into opensearch-project:main Oct 3, 2024
45 of 47 checks passed
@linghengqian linghengqian deleted the fix-doc branch October 4, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The processor documentation is missing sub-documentation for otel_trace_raw and service_map_stateful
3 participants