Add s3 sink client options #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hai Yan <[email protected]>
oeyh
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter and
dlvenable
as code owners
dinujoh
reviewed
Sep 19, 2024
Comment on lines
+15
to
+16
| private static final int DEFAULT_MAX_CONNECTIONS = 50; | ||
| private static final Duration DEFAULT_ACQUIRE_TIMEOUT = Duration.ofSeconds(10); |
There was a problem hiding this comment.
Are these the default values for SdkAsyncHttpClient ?
There was a problem hiding this comment.
This is going to be new defaults for every new S3 sink pipeline?
There was a problem hiding this comment.
Good question. I didn't change how the S3 async client is built when client options are not provided. So the pipeline should remain the same before and after this change if client options are not explicitly configured.
dinujoh
previously approved these changes
Sep 19, 2024
dlvenable
previously approved these changes
Sep 19, 2024
| private static final Duration DEFAULT_ACQUIRE_TIMEOUT = Duration.ofSeconds(10); | ||
|
|
||
| @JsonProperty("max_connections") | ||
| @Min(1) |
There was a problem hiding this comment.
Can we give a sanity upper bound? Maybe 5000?
san81
approved these changes
Sep 19, 2024
Signed-off-by: Hai Yan <[email protected]>
4 tasks
dlvenable
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds max_connections and acquire_timeout options to s3 sink client.
Example:
Issues Resolved
Resolves #4949
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.