Fix Router performance issue #4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
dlvenable and
oeyh
as code owners
graytaylor0
previously approved these changes
Mar 25, 2024
dlvenable
requested changes
Mar 25, 2024
| @@ -24,11 +24,13 @@ public class Router { | |||
| private final RouteEventEvaluator routeEventEvaluator; | |||
| private final DataFlowComponentRouter dataFlowComponentRouter; | |||
| private final Consumer<Event> noRouteHandler; | |||
| private Set<Record> recordsUnRouted; | |||
There was a problem hiding this comment.
This is not thread-safe. Is there a particular reason you moved it to the field? I say we just keep this as a local variable.
There was a problem hiding this comment.
This should help make it final:
final Set<Record> recordsUnRouted;
if (!allRecordsRouted) {
recordsUnRouted = new HashSet<>(allRecords);
} else {
recordsUnRouted = null;
}
Signed-off-by: Krishna Kondaka <[email protected]>
graytaylor0
approved these changes
Mar 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Fix Router performance issue Signed-off-by: Krishna Kondaka <[email protected]> * Addressed comments Signed-off-by: Krishna Kondaka <[email protected]> --------- Signed-off-by: Krishna Kondaka <[email protected]> Co-authored-by: Krishna Kondaka <[email protected]> (cherry picked from commit 51ee0df)
dlvenable
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Fix Router performance issue Signed-off-by: Krishna Kondaka <[email protected]> * Addressed comments Signed-off-by: Krishna Kondaka <[email protected]> --------- Signed-off-by: Krishna Kondaka <[email protected]> Co-authored-by: Krishna Kondaka <[email protected]> (cherry picked from commit 51ee0df) Co-authored-by: Krishna Kondaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Router performance issue.
PR #3959 added
removeAllto Router code. This method is very expensive in cases with ArrayLists(). Replacing it with for loop that removes individual records.Also, added a performance optimization to avoid populating
recordsUnRoutedif there is at least one sink to which all records are routed.Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.