Truncate Processor: Add support to truncate all fields in an event #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
reviewed
Mar 22, 2024
| final int startIndex = entry.getStartAt() == null ? 0 : entry.getStartAt(); | ||
| final Integer length = entry.getLength(); | ||
| if (truncateWhen != null && !expressionEvaluator.evaluateConditional(truncateWhen, recordEvent)) { | ||
| continue; | ||
| } | ||
| boolean truncateAll = false; | ||
| for (String sourceKey : sourceKeys) { | ||
| if (sourceKey.equals("*")) { |
There was a problem hiding this comment.
This seems like we may be introducing a concept that could cause confusion. What if we change the behavior of source_keys to not require any input and make the default be all fields?
…l keys Signed-off-by: Krishna Kondaka <[email protected]>
dlvenable
previously approved these changes
Mar 23, 2024
oeyh
reviewed
Mar 25, 2024
| @@ -26,14 +24,18 @@ public static class Entry { | |||
| @JsonProperty("length") | |||
| private Integer length; | |||
|
|
|||
| @JsonProperty("do_recursively") | |||
There was a problem hiding this comment.
This seems a bit verbose, maybe "recursive" is clear enough?
There was a problem hiding this comment.
@oeyh , I like that suggestion.
Signed-off-by: Krishna Kondaka <[email protected]>
dlvenable
approved these changes
Mar 25, 2024
oeyh
approved these changes
Mar 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
…4317) Truncate Processor: Add support to truncate all fields in an event Signed-off-by: Krishna Kondaka <[email protected]> Co-authored-by: Krishna Kondaka <[email protected]> (cherry picked from commit 8a7132d)
dlvenable
pushed a commit
that referenced
this pull request
Mar 26, 2024
…4317) (#4326) Truncate Processor: Add support to truncate all fields in an event Signed-off-by: Krishna Kondaka <[email protected]> Co-authored-by: Krishna Kondaka <[email protected]> (cherry picked from commit 8a7132d) Co-authored-by: Krishna Kondaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports truncating all fields in an event when
source_keysis not specified or null.The config would look like this to truncate all fields to a length of 5 characters.
Also, added support to do truncation recursively in case of nested objects with config option
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.