Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geoip integration tests #4173

Closed
wants to merge 16 commits into from
Closed

Geoip integration tests #4173

wants to merge 16 commits into from

Conversation

asifsmohammed
Copy link
Collaborator

@asifsmohammed asifsmohammed commented Feb 22, 2024 •
edited
Loading

Description

Add integration tests for geoip processor.
This has to be rebased from this branch once it's merged. #4167
Only changes required for integration tests are in GeoIPProcessorIT.java and build.gradle files. Other changes are in above PR.

Issues Resolved

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@asifsmohammed
Add when condition to each entry
2587122 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Addressed feedback by updating metric names
909d8f7 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Updated metric logic and Added new test
c67b88c 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Reverted when condition to processor level
b9ede5b 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Update database updater logic and added some boilerplate code
073c458 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Geoip database readers update
1493e54 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Geoip processor implementation
35228df 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Add tests to CDN download service
6c465af 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Rebased from main
63f3def 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Fixed geoip filed to database relation
b0e2ec5 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Addressed feedback
ebeb0fd 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Addressed feedback
289791c 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Added backoff and updated config
83210d4 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Geoip tagging and metrics
594d72d 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Reduce test coverage for build to pass in github
4462222 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed
Add geoip integration tests
d7cd8f2 
Signed-off-by: Asif Sohail Mohammed <[email protected]>
@dlvenable dlvenable mentioned this pull request Mar 28, 2024
Merged
4 tasks
@dlvenable
Copy link
Member

I cherry picked the main commit from this PR into my own branch. Then I did some work to clean it up and get it running again.

This PR can be replaced by #4353.

@dlvenable
Copy link
Member

Closing this now that #4353 is merged.

@dlvenable dlvenable closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sb2k16 sb2k16 Awaiting requested review from sb2k16 sb2k16 will be requested when the pull request is marked ready for review sb2k16 is a code owner

@chenqi0805 chenqi0805 Awaiting requested review from chenqi0805 chenqi0805 will be requested when the pull request is marked ready for review chenqi0805 is a code owner

@engechas engechas Awaiting requested review from engechas engechas will be requested when the pull request is marked ready for review engechas is a code owner

@san81 san81 Awaiting requested review from san81 san81 will be requested when the pull request is marked ready for review san81 is a code owner

@srikanthjg srikanthjg Awaiting requested review from srikanthjg srikanthjg will be requested when the pull request is marked ready for review srikanthjg is a code owner

@graytaylor0 graytaylor0 Awaiting requested review from graytaylor0 graytaylor0 will be requested when the pull request is marked ready for review graytaylor0 is a code owner

@dinujoh dinujoh Awaiting requested review from dinujoh dinujoh will be requested when the pull request is marked ready for review dinujoh is a code owner

@kkondaka kkondaka Awaiting requested review from kkondaka kkondaka will be requested when the pull request is marked ready for review kkondaka is a code owner

@KarstenSchnitter KarstenSchnitter Awaiting requested review from KarstenSchnitter KarstenSchnitter will be requested when the pull request is marked ready for review KarstenSchnitter is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable will be requested when the pull request is marked ready for review dlvenable is a code owner

@oeyh oeyh Awaiting requested review from oeyh oeyh will be requested when the pull request is marked ready for review oeyh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asifsmohammed @dlvenable