Adds max_request_length as a configuration for the http and OTel sources #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource, otel_metrics_source, and otel_logs_source sources. Resolves opensearch-project#3931 Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
kkondaka
approved these changes
Jan 12, 2024
kkondaka
requested changes
Jan 12, 2024
Signed-off-by: David Venable <[email protected]>
kkondaka
approved these changes
Jan 12, 2024
chenqi0805
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new configuration
max_request_lengthto the HTTP/gRPC sources (OTel). If the size of a request exceeds that size these sources will return a413 Request Entity Too Large.This also adds support for parsing
ByteCountto the plugin object mapper.There is also a new method on
ByteCountto create an instance of a given size to help with testing.Issues Resolved
Resolves #3931
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.