Disable the circuit breaker for buffers that write data off-heap only… #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This is currently only the Kafka buffer. Resolves opensearch-project#3616 Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
… in the BufferTest class. Signed-off-by: David Venable <[email protected]>
kkondaka
approved these changes
Nov 10, 2023
hshardeesi
reviewed
Nov 10, 2023
| @@ -92,6 +92,17 @@ default Duration getDrainTimeout() { | |||
| return Duration.ZERO; | |||
| } | |||
|
|
|||
| /** | |||
| * Indicates if writes to this buffer are also in some way written | |||
| * onto the JVM heap. If writes do go on heap, this should <b>false</b> | |||
hshardeesi
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables the circuit breaker for writes to the
kafkabuffer. It does this by adding a newisWrittenOffHeapOnlyboolean method to theBufferinterface.Additionally this PR updates
MultiBufferDecoratorto use theDelegatingBufferto reduce some of the code. And moves it to be package protected in the.parserpackage.Issues Resolved
Resolves #3616
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.