Split loading plugin arguments from the Application Context #3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
…s for providing arguments from the Application Context to plugin parameters. Signed-off-by: David Venable <[email protected]>
dlvenable
force-pushed
the
improve-plugin-context-from-application-context
branch
from
c24d189 to
c09e0f6
Compare
chenqi0805
approved these changes
Nov 14, 2023
| private final PluginConfigurationObservableFactory pluginConfigurationObservableFactory; | ||
| private final CircuitBreaker circuitBreaker; | ||
| private final ApplicationContextToTypedSuppliers applicationContextToTypedSuppliers; |
There was a problem hiding this comment.
Shall we use interface instead of implementation here?
There was a problem hiding this comment.
This is an internal class that I don't think needs to be split. We could do later if we found a need, but at this point I think just the class is ok.
kkondaka
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When working on #3595, I found that adding a new type directly from the Application Context into a Data Prepper plugin constructor requires quite a few code touches. Not only that, but it becomes hard to test new types like
CircuitBreakerthat are optional and can benull.This PR splits the work for getting instances from the Application Context into a new class -
ApplicationContextToTypedSuppliers. Any type that is just passed directly can use this mechanisms.Some classes remain in
DefaultPluginFactorybecause there is additional logic within the plugin framework for them. For example, they are special arguments per-plugin, or additional work is performed from them (e.g. BeanFactory and PluginConfigurationObservableFactory).Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.