Add dynamodb_item_version metadata that is derived from timestamp for… #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stream events Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
previously requested changes
Nov 7, 2023
| public void addToBuffer(final AcknowledgementSet acknowledgementSet, | ||
| final Map<String, Object> data, | ||
| final Map<String, Object> keys, | ||
| long eventCreationTimeMillis, |
There was a problem hiding this comment.
We should make these two parameters final.
|
|
||
| // Only set external origination time for stream events, not export | ||
| if (eventName != null) { | ||
| event.getEventHandle().setExternalOriginationTime(Instant.ofEpochMilli(eventCreationTimeMillis)); |
There was a problem hiding this comment.
You also should set it on the EventMetadata.
| recordsSeenThisSecond++; | ||
| } | ||
|
|
||
| return eventTimeInSeconds.toEpochMilli() * 1000 + recordsSeenThisSecond; |
There was a problem hiding this comment.
What happens when there are more than 1000 records in a second?
There was a problem hiding this comment.
It would be an issue, but we would have to get 1000 records in same shard, which is impossible at this time
Signed-off-by: Taylor Gray <[email protected]>
kkondaka
approved these changes
Nov 8, 2023
graytaylor0
dismissed
dlvenable’s stale review
Addressing comments in follow up PR
|
Addressed the comments from @dlvenable |
hshardeesi
approved these changes
Nov 8, 2023
oeyh
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… stream events
Description
This change adds a new metadata field for DymamoDB Events,
dynamodb_item_version. This version is derived from the timestamp for stream events, and set to0Lfor export Events, in order to give stream events precedence over exportThis change also writes stream event timestamps to the
externalOriginationMetadatafor stream Events. This will provide an out of the box external latency metric for ddb streams.The
dynamodb_item_versionmetadata is intended for use with thedocument_versionfield of the OpenSearch sink to always take the latest Events.Since the timestamp for stream Events is in seconds, we are differentiating stream events received in the same second for a shard with the formula
ddb_version = ddbEventTimestamp.getEpochSecond() * 1_000_000 + recordsSeenThisSecond.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.