addressing review comments

Signed-off-by: Santhosh Gandhe <[email protected]>
opensearch-project · Jan 27, 2025 · e2fd7be · e2fd7be
1 parent 3d7e2f0
commit e2fd7be
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/...ira-source/src/main/java/org/opensearch/dataprepper/plugins/source/jira/JiraItemInfo.java b/...ira-source/src/main/java/org/opensearch/dataprepper/plugins/source/jira/JiraItemInfo.java
@@ -77,7 +77,7 @@ public Map<String, Object> getKeyAttributes() {
     @Override
     public Instant getLastModifiedAt() {
         long updatedAtMillis = getMetadataField(Constants.UPDATED);
-        long createdAtMillis = getMetadataField(CREATED);
+        long createdAtMillis = getMetadataField(Constants.CREATED);
         return createdAtMillis > updatedAtMillis ?
                 Instant.ofEpochMilli(createdAtMillis) : Instant.ofEpochMilli(updatedAtMillis);
     }

diff --git a/...source/src/test/java/org/opensearch/dataprepper/plugins/source/jira/JiraItemInfoTest.java b/...source/src/test/java/org/opensearch/dataprepper/plugins/source/jira/JiraItemInfoTest.java
@@ -15,6 +15,7 @@
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
+import org.opensearch.dataprepper.plugins.source.jira.utils.Constants;
 
 import java.time.Instant;
 import java.util.Map;
@@ -95,12 +96,12 @@ void testGetPartitionKey() {
 
     @Test
     void testGetLastModifiedAt() {
-        when(metadata.getOrDefault("updated", "0")).thenReturn("5");
-        when(metadata.getOrDefault("created", "0")).thenReturn("0");
+        when(metadata.get(Constants.UPDATED)).thenReturn("5");
+        when(metadata.get(Constants.CREATED)).thenReturn("0");
         assertEquals(Instant.ofEpochMilli(5), jiraItemInfo.getLastModifiedAt());
 
-        when(metadata.getOrDefault("updated", "0")).thenReturn("5");
-        when(metadata.getOrDefault("created", "0")).thenReturn("7");
+        when(metadata.get(Constants.UPDATED)).thenReturn("5");
+        when(metadata.get(Constants.CREATED)).thenReturn("7");
         assertEquals(Instant.ofEpochMilli(7), jiraItemInfo.getLastModifiedAt());
     }
 

diff --git a/.../test/java/org/opensearch/dataprepper/plugins/source/source_crawler/base/CrawlerTest.java b/.../test/java/org/opensearch/dataprepper/plugins/source/source_crawler/base/CrawlerTest.java
@@ -36,7 +36,6 @@
 @ExtendWith(MockitoExtension.class)
 public class CrawlerTest {
     private static final int DEFAULT_BATCH_SIZE = 50;
-    Instant lastPollTime = Instant.ofEpochMilli(0);
     @Mock
     private AcknowledgementSet acknowledgementSet;
     @Mock
@@ -50,6 +49,7 @@ public class CrawlerTest {
     @Mock
     private LeaderPartition leaderPartition;
     private Crawler crawler;
+    private final Instant lastPollTime = Instant.ofEpochMilli(0);
 
     @BeforeEach
     public void setup() {