fixed failing tests

Signed-off-by: Krishna Kondaka <[email protected]>
opensearch-project · Jul 24, 2024 · a2a9afd · a2a9afd
1 parent 737ae43
commit a2a9afd
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/...ava/org/opensearch/dataprepper/plugins/sink/opensearch/OpenSearchClientRefresherTest.java b/...ava/org/opensearch/dataprepper/plugins/sink/opensearch/OpenSearchClientRefresherTest.java
@@ -71,6 +71,7 @@ void testGet() {
     @Test
     void testGetAfterUpdateWithDeprecatedBasicAuthUnchanged() {
         final OpenSearchClientRefresher objectUnderTest = createObjectUnderTest();
+        assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         verify(clientFunction, times(1)).apply(any());
         when(connectionConfiguration.getUsername()).thenReturn(TEST_USERNAME);
         when(connectionConfiguration.getPassword()).thenReturn(TEST_PASSWORD);
@@ -91,6 +92,7 @@ void testGetAfterUpdateWithDeprecatedBasicAuthUnchanged() {
     @Test
     void testGetAfterUpdateWithBasicAuthUnchanged() {
         final OpenSearchClientRefresher objectUnderTest = createObjectUnderTest();
+        assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         verify(clientFunction, times(1)).apply(any());
         when(connectionConfiguration.getAuthConfig()).thenReturn(authConfig);
         when(authConfig.getUsername()).thenReturn(TEST_USERNAME);
@@ -115,6 +117,7 @@ void testGetAfterUpdateWithBasicAuthUnchanged() {
     void testGetAfterUpdateWithDeprecatedUsernameChanged() {
         when(pluginMetrics.counter(CREDENTIALS_CHANGED)).thenReturn(credentialsChangeCounter);
         final OpenSearchClientRefresher objectUnderTest = createObjectUnderTest();
+        assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         verify(clientFunction, times(1)).apply(any());
         assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         when(connectionConfiguration.getUsername()).thenReturn(TEST_USERNAME);
@@ -138,6 +141,7 @@ void testGetAfterUpdateWithDeprecatedUsernameChanged() {
     void testGetAfterUpdateWithUsernameChanged() {
         when(pluginMetrics.counter(CREDENTIALS_CHANGED)).thenReturn(credentialsChangeCounter);
         final OpenSearchClientRefresher objectUnderTest = createObjectUnderTest();
+        assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         verify(clientFunction, times(1)).apply(any());
         assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         when(connectionConfiguration.getAuthConfig()).thenReturn(authConfig);
@@ -165,6 +169,7 @@ void testGetAfterUpdateWithUsernameChanged() {
     void testGetAfterUpdateWithDeprecatedPasswordChanged() {
         when(pluginMetrics.counter(CREDENTIALS_CHANGED)).thenReturn(credentialsChangeCounter);
         final OpenSearchClientRefresher objectUnderTest = createObjectUnderTest();
+        assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         verify(clientFunction, times(1)).apply(any());
         assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         when(connectionConfiguration.getUsername()).thenReturn(TEST_USERNAME);
@@ -190,6 +195,7 @@ void testGetAfterUpdateWithDeprecatedPasswordChanged() {
     void testGetAfterUpdateWithPasswordChanged() {
         when(pluginMetrics.counter(CREDENTIALS_CHANGED)).thenReturn(credentialsChangeCounter);
         final OpenSearchClientRefresher objectUnderTest = createObjectUnderTest();
+        assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         verify(clientFunction, times(1)).apply(any());
         assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         when(connectionConfiguration.getAuthConfig()).thenReturn(authConfig);
@@ -219,6 +225,7 @@ void testGetAfterUpdateClientFailure() {
         when(pluginMetrics.counter(CREDENTIALS_CHANGED)).thenReturn(credentialsChangeCounter);
         when(pluginMetrics.counter(CLIENT_REFRESH_ERRORS)).thenReturn(clientRefreshErrorsCounter);
         final OpenSearchClientRefresher objectUnderTest = createObjectUnderTest();
+        assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         verify(clientFunction, times(1)).apply(any());
         assertThat(objectUnderTest.get(), equalTo(openSearchClient));
         when(connectionConfiguration.getUsername()).thenReturn(TEST_USERNAME);
@@ -240,4 +247,4 @@ void testGetAfterUpdateClientFailure() {
         verify(clientRefreshErrorsCounter).increment();
         verify(clientFunction, times(2)).apply(any());
     }
-}
+}